tree 4a6b9813c5662bd6b4e54c434b357dbbf049edc8
parent 47adbc09dbc02673a7c8c3c9f3caa5592cb2497a
author Lei Zhang <thestig@chromium.org> 1653504704 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1653504704 +0000

Fix a DCHECK() failure inside FPDF_SaveAsCopy().

FPDF_SaveAsCopy() calls CPDF_Name::WriteTo() for name objects, but names
can be empty. Adjust WriteTo() to avoid writing out an empty name, as it
is effectively a no-op and the IFX_WriteStream implementation has a
DCHECK() to prevent that.

With this fix, the FPDFSaveEmbedderTest.Bug1328389 test case can be
enabled since it no longer crashes. Update the test case's expectations
to reflect what actually happens.

Bug: chromium:1328389
Change-Id: I5fffc93d8811afaa9ba0f0fb501032ebf1165dc8
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/93930
Reviewed-by: Nigi <nigi@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>