tree b1e8e01de83cdd97c8e8a99ffe8dd9bccf8bb7c9
parent 0c2edd77909a148ba032e00fa224ae9340a70000
author Hui Yingst <nigi@chromium.org> 1676679804 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1676679804 +0000

Update the CFX_FillRenderOptions used for flushing paths

Currently, CFX_SkiaDeviceDriver::PaintStroke() sets SkPaint based on
the most up-to-date CFX_FillRenderOptions `m_FillOptions`. But this
CFX_FillRenderOptions is not the same as the cached fill options
`m_fillOptions` in SkiaState when multiple paths with different
CFX_FillRenderOptions need drawing.

When CFX_SkiaDeviceDriver::PaintStroke() is called by
SkiaState::FlushPath(), it should set the SkPaint based on
`m_fillOptions` in the cached SkiaState, since FlushPath() is trying
to draw the already cached commands.

This CL makes the following improvements:
- Check if fill options have changed when determine when to flush
  cached paths.
- Make CFX_SkiaDeviceDriver::PaintStroke() take an
  CFX_FillRenderOptions as the input, so that the correct fill options
  can be used depending on the call site.

Change-Id: I120071431969d494afee7a0237d0b90273541527
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/103872
Commit-Queue: Nigi <nigi@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>