tree 478759a09cefbef7fa8c4955fd3e2a172a379971
parent 53cec0ad6b12d51f818199f8564b18893a844bd4
author Hui Yingst <nigi@chromium.org> 1693009996 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1693009996 +0000

[Skia] Fix issues for printing 24 BPP images

When using `CFX_SkiaDeviceDriver` for rendering to a 24 BPP bitmap, it
creates an internal bitmap buffer for fast processing and saves the
actual output bitmap as `m_pOriginalBitmap`. Keeping both the original
and the internal bitmaps up-to-date is the key to get the correct
printing result.

This CL improves the rendering process in the following ways:

1. For `CFX_SkiaDeviceDriver` only: Add
   `CFX_RenderDevice::SyncInternalBitmaps()` method to make the
   underlying `m_pDeviceDriver` transfer the rendering result from its
   internal buffer to the `CFX_RenderDevice` bitmap. This allows
   syncing without destroying the `m_pDeviceDriver`.

2. In `CPDF_DeviceBuffer::OutputToDevice()`, `pBuffer` is used for
   creating a `CFX_RenderDevice` already before it got passed into
   `GetBackground()` to be painted white. This means the "old"
   `CFX_RenderDevice`'s device driver contains an internal buffer
   that's out-dated (without the white paint). To keep the existing
   `CFX_RenderDevice` buffers fresh, use it as a parameter of
   `GetBackground()` and replace `pBuffer` so that its buffer gets
   updated and we can avoid creating a new layer of `CFX_RenderDevice`.

Also, removes the pixel tests that are fixed by this CL from the
suppression list.

Bug: chromium:1470768, pdfium:2054
Change-Id: I8442664ae58dc528442b40a8503100f9501f5ea1
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/111431
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Nigi <nigi@chromium.org>