tree d7bf16029999b8cb6ebcddf436bfbd14d3f22831
parent a836c20b87e15724980fbec73229b7dee531fca8
author Lei Zhang <thestig@chromium.org> 1694564188 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1694564188 +0000

Reinstate CPDF_FormField DCHECKs and improve SetValue()

Undo a small portion of https://pdfium-review.googlesource.com/111552
so SetItemSelection() and IsItemSelected() get their DCHECKs back.
Instead, fix the issue by changing the caller to avoid tripping the
DCHECKs. As part of this work:

- Use CHECK instead of DCHECK, per modern coding guidelines.
- Add an IsComboOrListField() helper function and use that everywhere.
- Add a HasOptField() helper function and use that as an additional
  guardrail to make sure CPDF_FormField only reads /Opt values when
  appropriate.
- Update FPDFAnnot_IsOptionSelected() to avoid tripping over the /Opt
  checks.

Bug: chromium:1477093
Change-Id: Id774393afcd8e976ffa7f2ae869ceac9c9680b06
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/111670
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>