tree 07d3458fdcf9cd5b1074d15b0027e6439a9e3076
parent 75ff13168ea0fd0c8ac8981722d15cce07fbdcf9
author Lei Zhang <thestig@chromium.org> 1694564392 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1694564392 +0000

Improve invalid ICC profile handling

Currently, when an ICC profile's component count does not match the
expected value in the ICC profile stream dictionary, CPDF_ICCBasedCS
will consider the entire ICC colorspace as invalid. This can result in
images not rendering.

Instead, plumb the expected component count into CPDF_IccProfile, and
let it detect this situation and mark the ICC profile as unsupported.
Then CPDF_ICCBasedCS will go through its unsupported ICC profile path
and try an alternate profile. This allows images to render correctly in
certain PDFs that do not fully follow the PDF spec.

Update CPDF_DocPageData to make its ICC caching code take the component
count into consideration to prevent rare cases where 2 ICC profile
stream dictionaries have the same ICC data, but different component
counts.

Test this scenario with a pixel test. The pixel test is a mashup of the
existing matte.in pixel test with ICC data from the
fx/color/color_icc_based.pdf corpus test.

Bug: chromium:1479436
Change-Id: If331ecf06dba88232dd6f2e13b0e1354dc405074
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/111731
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>