tree 403bb56995c3aa53d0ac57fcbe783fafa62d6cc4
parent 55835a2c6af83c4d78394c50670e97606b8b7eef
author Lei Zhang <thestig@chromium.org> 1694827498 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1694827498 +0000

Don't implement CPDF_DIB::GetBuffer() (try 2)

The first try [1] to just return an empty span in CPDF_DIB::GetBuffer()
did not work. This CL goes further and deletes CFX_DIBBase::GetBuffer()
altogether. Instead, only implement a non-virtual
CFX_DIBBitmap::GetBuffer(). To make this work, get rid of all
CFX_DIBBase::GetBuffer() callers:

- Switch to calling CFX_DIBBitmap::GetBuffer() when it easy to do so.
- Make CFX_DIBBase::RealizeIfNeeded() virtual, and change the default
  implementation to just call Realize().
- Make RealizeIfNeeded() available for Skia-builds and use it in
  CreateSkiaImageFromDib().
- Change CreateSkiaImageFromTransformedDib() to only use scanlines.

Fix other issues to make sure everything works:

- Avoid calling RealizeIfNeeded() on `CPDF_DIB::m_pCachedBitmap`, as
  that gives the wrong answer, just like CPDF_DIB::GetBuffer().
- Make sure CreateSkiaImageFromDib() does not fail and leak memory.
- Give up on avoiding the CachedImage::SkipToScanline() call.
- Add a test case for a related bug.

[1] https://pdfium-review.googlesource.com/108850

Bug: chromium:1478366,pdfium:2050,pdfium:2051
Change-Id: Ia20d4d257d441dd971ee0a912733f48f29dafad1
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/111434
Reviewed-by: Nigi <nigi@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>