tree f4ba5553182b7f361b8c3ba6602133207fb22849
parent 700b9fbf86eec2cdca1c7560bd5d14c5b2fbb25d
author Lei Zhang <thestig@chromium.org> 1695079093 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1695079093 +0000

Remove unreachable code from CFX_DIBBase::ConvertTo()

CFX_DIBBase::ConvertTo() first handles the case where the source and
destination formats are the same. Then it proceeds to handle the `kArgb`
format, which is also the only format with an alpha channel. When the
destination format is `kArgb`, the only way for `pSrcAlpha` to be
non-null is for the source format to also be `kArgb`. Since this case
has also been handled, it cannot occur again. After removing this
unreachable code, the code to set `pSrcAlpha` also becomes useless.

Change-Id: I544c2dcacb156140f1cace64fe38c23fd3f69c2c
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/111930
Reviewed-by: Nigi <nigi@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>