tree 04becef7e717c71c1570456977a6cb808034d929
parent 9217138bd1a688f67be61af2130a9f3b48081209
author Lei Zhang <thestig@chromium.org> 1697494629 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1697494629 +0000

Remove NOTREACHED() in core/fxcrt/css

Rearrange code in CFX_CSSStyleSelector::ApplyProperty(). Currently, the
logic is:

```
if (negative_cond) {
  BodyA();
} elif (!negative_cond) {
  BodyB();
} else {
  NOTREACHED();
}
```

Replace this with:

```
if (cond) {
  BodyB();
  return;
}

BodyA();
```

Also switch to NOTREACHED_NORETURN() in CFX_CSSDeclaration.

Bug: pdfium:2008
Change-Id: I44f365183c0b3199b5fbeb7f653a64a1b5f15cb8
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/112710
Reviewed-by: Nigi <nigi@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>