Enforce checkdeps when submitting CLs
Make the presubmit that runs before CL commits check for unwanted
includes using the checkdeps tool. This ensures developers do not
bypass that check during CL uploads, by enforcing the check on the
presubmit try bot.
Change-Id: I2232bde21b92c91443a0cf94ed5da9f9f07efd2c
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/116653
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Thomas Sepez <tsepez@google.com>
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 3d5a231..9bce21d 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -499,6 +499,7 @@
results.extend(
input_api.canned_checks.PanProjectChecks(
input_api, output_api, project_name='PDFium'))
+ results.extend(_CheckUnwantedDependencies(input_api, output_api))
# PanProjectChecks() doesn't consider .gn/.gni files, so check those, too.
files_to_check = (
@@ -519,7 +520,6 @@
def CheckChangeOnUpload(input_api, output_api):
results = []
results.extend(_CheckNoBannedFunctions(input_api, output_api))
- results.extend(_CheckUnwantedDependencies(input_api, output_api))
results.extend(
input_api.canned_checks.CheckPatchFormatted(input_api, output_api))
results.extend(
