Reland "Add --jitless to recommended v8 flags."
This reverts commit 0f22f9d0bf7f5cb2aa88eb6d6fb425ce761229c6.
Reason for revert: v8 has been rolled forward to support --jitless.
Original change's description:
> Revert "Add --jitless to recommended v8 flags."
>
> This reverts commit 33cc9c60892a0d527bf7aee95c8be8d298119efd.
>
> Reason for revert: V8 is not ready yet.
> The PDF from https://crbug.com/306123 triggers a DCHECK failure in V8.
>
> Original change's description:
> > Add --jitless to recommended v8 flags.
> >
> > Now that v8 supports this mode, save some memory and avoid
> > creating RWX pages in the processes running pdfium.
> >
> > Change-Id: I7e28331487812abdfef3c9b4fa1a71fb492aba0a
> > Reviewed-on: https://pdfium-review.googlesource.com/c/49670
> > Reviewed-by: Lei Zhang <thestig@chromium.org>
> > Commit-Queue: Tom Sepez <tsepez@chromium.org>
>
> TBR=thestig@chromium.org,tsepez@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Change-Id: I28f378a2b54d068a4c7f2a015e1a3767ac738b89
> Reviewed-on: https://pdfium-review.googlesource.com/c/49890
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Commit-Queue: Lei Zhang <thestig@chromium.org>
TBR=thestig@chromium.org,tsepez@chromium.org
Change-Id: I0b02a497e40cd0e3a0b0a4d15a19a7a1f9d59f90
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://pdfium-review.googlesource.com/c/50310
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
diff --git a/fpdfsdk/fpdf_view.cpp b/fpdfsdk/fpdf_view.cpp
index d078600..0123035 100644
--- a/fpdfsdk/fpdf_view.cpp
+++ b/fpdfsdk/fpdf_view.cpp
@@ -1062,7 +1062,8 @@
#ifdef PDF_ENABLE_V8
FPDF_EXPORT const char* FPDF_CALLCONV FPDF_GetRecommendedV8Flags() {
// Reduce exposure since no PDF should contain web assembly.
- return "--no-expose-wasm";
+ // Use interpreted JS only to avoid RWX pages in our address space.
+ return "--no-expose-wasm --jitless";
}
#endif // PDF_ENABLE_V8
