)]}'
{
  "commit": "0e5bab1b8402b65fa09a36a2b141bbf22291f822",
  "tree": "e6d714f10fc9c552ea043073d17047f969f28f13",
  "parents": [
    "ae2aec8712aa4c52454737467869b9d256baa05f"
  ],
  "author": {
    "name": "Tom Sepez",
    "email": "tsepez@chromium.org",
    "time": "Thu Oct 18 21:39:40 2018 +0000"
  },
  "committer": {
    "name": "Chromium commit bot",
    "email": "commit-bot@chromium.org",
    "time": "Thu Oct 18 21:39:40 2018 +0000"
  },
  "message": "Remove PrintParams object.\n\nThe only way to theoretically get one is via doc.getPrintParams(),\nand it always returns in error.\n\nEven if one were returend to JS, there aren\u0027t any methods/callbacks\nto change its properties.\n\nEven if there were methods to change its properties, the information\nit stores doesn\u0027t align with what is in the JS spec for this object.\n\nEven if it were aligned with the JS spec, the way we check for its\npresence as the ninth parameter in CJS_Document::print() doesn\u0027t\nmatch the way its use is documented in the spec as the sole\nfirst parameter.\n\nInstead implement the older, simpler behaviour as spec\u0027d prior to\n6.0, and toss this enhancement altogether.\n\nMove function to check the result of ExpandKeywordParams() to\njs_define.h so other files can use it. Update comment in that\nfile to remove reference to deprecated enum.\n\nExpand test for API and introduce callback to log parameters.\n\nChange-Id: I047e2be0d2afbad91d6b58c6c74bbea083fed330\nReviewed-on: https://pdfium-review.googlesource.com/c/44271\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "2022d3b7358a8967c897be4a48023b7869c29ef9",
      "old_mode": 33188,
      "old_path": "fxjs/BUILD.gn",
      "new_id": "5f475edd7a9e3e7b2335fb3e2a2008db7f5c66dc",
      "new_mode": 33188,
      "new_path": "fxjs/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "e2177530621b690239af8dc49a30e653b6149927",
      "old_mode": 33188,
      "old_path": "fxjs/cjs_app.cpp",
      "new_id": "f279250fb06d92921d03366eb7e17a376faae5f0",
      "new_mode": 33188,
      "new_path": "fxjs/cjs_app.cpp"
    },
    {
      "type": "modify",
      "old_id": "2ecfd424d2575ea8399560ed940fb840166ed83c",
      "old_mode": 33188,
      "old_path": "fxjs/cjs_document.cpp",
      "new_id": "a0dd2ece9169c822f0cfbed7cc96d50d8114bd3f",
      "new_mode": 33188,
      "new_path": "fxjs/cjs_document.cpp"
    },
    {
      "type": "delete",
      "old_id": "37ff956f741b0f656933551262df7773ea051925",
      "old_mode": 33188,
      "old_path": "fxjs/cjs_printparamsobj.cpp",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "delete",
      "old_id": "f8b055729ce50e66b690ad4a6953330caf74e8fe",
      "old_mode": 33188,
      "old_path": "fxjs/cjs_printparamsobj.h",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "modify",
      "old_id": "3bc8448435196085737e9a881da428dd58dce649",
      "old_mode": 33188,
      "old_path": "fxjs/cjs_runtime.cpp",
      "new_id": "3914b3671585e23f9b164c6bd57f4d0ab7a9547e",
      "new_mode": 33188,
      "new_path": "fxjs/cjs_runtime.cpp"
    },
    {
      "type": "modify",
      "old_id": "0a18b6d15b3b0ddd8aa5b5f756e3bd2d89ce544b",
      "old_mode": 33188,
      "old_path": "fxjs/js_define.cpp",
      "new_id": "54bd8e1c3a3a20ddd886bc61ccbb69ca59da653d",
      "new_mode": 33188,
      "new_path": "fxjs/js_define.cpp"
    },
    {
      "type": "modify",
      "old_id": "bf7aa35504448e45673e2ceb1e6c79c7272be9d3",
      "old_mode": 33188,
      "old_path": "fxjs/js_define.h",
      "new_id": "0705dfea6baac0f933bbf2e25ca68189586a1848",
      "new_mode": 33188,
      "new_path": "fxjs/js_define.h"
    },
    {
      "type": "modify",
      "old_id": "e64382c911f34d0fbeff5020a5cf76eb9f616393",
      "old_mode": 33188,
      "old_path": "samples/pdfium_test.cc",
      "new_id": "c5c298d23e68a5dc8630d77daf16d0ab9cb45e6b",
      "new_mode": 33188,
      "new_path": "samples/pdfium_test.cc"
    },
    {
      "type": "modify",
      "old_id": "0188d7c2379c26fe14e260b4150a424523495937",
      "old_mode": 33188,
      "old_path": "testing/resources/javascript/document_methods.in",
      "new_id": "bb7af748d8d786127f88f0170f6b1e06d003af98",
      "new_mode": 33188,
      "new_path": "testing/resources/javascript/document_methods.in"
    },
    {
      "type": "modify",
      "old_id": "01bf0ed0bd5a11c46aa256aa24aa64c238d3b5ed",
      "old_mode": 33188,
      "old_path": "testing/resources/javascript/document_methods_expected.txt",
      "new_id": "e39690ba457bcff8b89438f661143c5b566a5a07",
      "new_mode": 33188,
      "new_path": "testing/resources/javascript/document_methods_expected.txt"
    }
  ]
}