commit 1d78f4dd34637bf9a16411f64816ef87cb128165
author Tom Sepez <tsepez@chromium.org> Mon Oct 22 20:17:38 2018 +0000
committer Chromium commit bot <commit-bot@chromium.org> Mon Oct 22 20:17:38 2018 +0000
tree 77104342c1fce39d48dd97d763a363224a25f660
parent ae9bed9f4af146dc52c591d4122f32f733b2f321

Remove pdfium_diff target from pdf_is_standalone block.

Allows it to be built as part of a chromium checkout so that
the official coverage tools may invoke it as part of the coverage
generation scripts.

Change-Id: I8ed49f789a6a7e7eaa8ece4ef068295b0942cc45
Reviewed-on: https://pdfium-review.googlesource.com/c/44490
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn
index c19e222..53a633b 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -340,6 +340,21 @@
   }
 }
 
+executable("pdfium_diff") {
+  testonly = true
+  sources = [
+    "testing/image_diff/image_diff.cpp",
+  ]
+  deps = [
+    ":pdfium",
+    "testing/image_diff",
+    "//build/win:default_exe_manifest",
+  ]
+  configs -= [ "//build/config/compiler:chromium_code" ]
+  configs += [ "//build/config/compiler:no_chromium_code" ]
+  configs += [ ":pdfium_core_config" ]
+}
+
 if (pdf_is_standalone) {
   jumbo_source_set("samples") {
     testonly = true
@@ -348,21 +363,6 @@
     ]
   }
 
-  executable("pdfium_diff") {
-    testonly = true
-    sources = [
-      "testing/image_diff/image_diff.cpp",
-    ]
-    deps = [
-      ":pdfium",
-      "testing/image_diff",
-      "//build/win:default_exe_manifest",
-    ]
-    configs -= [ "//build/config/compiler:chromium_code" ]
-    configs += [ "//build/config/compiler:no_chromium_code" ]
-    configs += [ ":pdfium_core_config" ]
-  }
-
   group("fuzzers") {
     testonly = true
     deps = [
@@ -374,13 +374,13 @@
 group("pdfium_all") {
   testonly = true
   deps = [
+    ":pdfium_diff",
     ":pdfium_embeddertests",
     ":pdfium_unittests",
   ]
   if (pdf_is_standalone) {
     deps += [
       ":fuzzers",
-      ":pdfium_diff",
       ":samples",
     ]
   }