)]}'
{
  "commit": "1e7df19a137f290064bc098e9ccbf82232197285",
  "tree": "5c1222d3393258a199dfcf326f163ae4c40d455f",
  "parents": [
    "b01d300985266439e7112b03201d49dddd8f3ee5"
  ],
  "author": {
    "name": "Lei Zhang",
    "email": "thestig@chromium.org",
    "time": "Fri Sep 04 02:12:42 2020 +0000"
  },
  "committer": {
    "name": "Chromium commit bot",
    "email": "commit-bot@chromium.org",
    "time": "Fri Sep 04 02:12:42 2020 +0000"
  },
  "message": "Revert \"Optimize a tight loop in FX_Number.\"\n\nThis reverts commit 67fd772899491dbe32306dfec48a5bbb005feb9b.\n\nReason for revert: Regressed PDF loading. See bug for details.\n\nOriginal change\u0027s description:\n\u003e Optimize a tight loop in FX_Number.\n\u003e \n\u003e While doing string to int conversion:\n\u003e 1) Remove a redundant std::isdigit() call.\n\u003e 2) Don\u0027t call CheckedNumeric::IsValid() in this case.\n\u003e - It\u0027s almost always valid.\n\u003e - Continuing in an invalid state does not cause any security issues.\n\u003e \n\u003e Change-Id: I4473b1ec020cd56e241276c21e35c25b5af5a144\n\u003e Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/72250\n\u003e Reviewed-by: Tom Sepez \u003ctsepez@chromium.org\u003e\n\u003e Commit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\n\nBug: chromium:1124998\nTBR\u003dtsepez@chromium.org\n\n# Not skipping CQ checks because original CL landed \u003e 1 day ago.\n\nChange-Id: Ie616692ddbac3a2313c12a2563274ad19c7813c5\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/73336\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "99e9f4175f135e1b4d06d0c30d3388164dd8ae25",
      "old_mode": 33188,
      "old_path": "core/fxcrt/fx_number.cpp",
      "new_id": "178ede973db1a4f1174f940061f8f0489fa1e531",
      "new_mode": 33188,
      "new_path": "core/fxcrt/fx_number.cpp"
    }
  ]
}
