)]}'
{
  "commit": "1fe1f39ee3fa56c01256725761765ec111a1973e",
  "tree": "1ac519ddabd3994d25ef6db239cbfabea7f11365",
  "parents": [
    "1268b5943b4d08ed06dbe1a91ee45f3f522991a5"
  ],
  "author": {
    "name": "Tom Sepez",
    "email": "tsepez@chromium.org",
    "time": "Wed Mar 13 22:40:11 2019 +0000"
  },
  "committer": {
    "name": "Chromium commit bot",
    "email": "commit-bot@chromium.org",
    "time": "Wed Mar 13 22:40:11 2019 +0000"
  },
  "message": "Revert \"Replace some in/out parameters in cfgas_stringformatter.cpp\"\n\nThis reverts commit 1268b5943b4d08ed06dbe1a91ee45f3f522991a5.\n\nReason for revert: Adding state to formatter may be cleaner than passing arguments\n\nOriginal change\u0027s description:\n\u003e Replace some in/out parameters in cfgas_stringformatter.cpp\n\u003e \n\u003e Doing so allows the optimizer to remove another bounds check\n\u003e in GetLiteralText() since there is less aliasing possible.\n\u003e \n\u003e - small logic tidy in FormatDateTime()\n\u003e - consolidate FormatNull() and FormatZero() implementations.\n\u003e \n\u003e Change-Id: If7b2e7acc1b01ccb64792510a64286016c623ad0\n\u003e Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/51850\n\u003e Commit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\n\u003e Reviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\n\nTBR\u003dthestig@chromium.org,tsepez@chromium.org\n\nChange-Id: I3782a469b3e4273c280c6a441d1f096c0ba8ee12\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/51870\nReviewed-by: Tom Sepez \u003ctsepez@chromium.org\u003e\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "2118b08e6f40a0be669c35145eb9b2dbe1deaf6e",
      "old_mode": 33188,
      "old_path": "xfa/fgas/crt/cfgas_stringformatter.cpp",
      "new_id": "ee8321fb65369fdbf6fdb585aba896e52e6aef3b",
      "new_mode": 33188,
      "new_path": "xfa/fgas/crt/cfgas_stringformatter.cpp"
    },
    {
      "type": "modify",
      "old_id": "cc534f42031de54d6c5ddfd46d3743102e19e936",
      "old_mode": 33188,
      "old_path": "xfa/fgas/crt/cfgas_stringformatter.h",
      "new_id": "958372460c8b70703e81f14ba12415e4e303b49a",
      "new_mode": 33188,
      "new_path": "xfa/fgas/crt/cfgas_stringformatter.h"
    }
  ]
}