commit 2564664eb8cf0a5c23b44c8d221d6e78b75de943
author Hui Yingst <nigi@chromium.org> Mon Oct 19 19:49:18 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Mon Oct 19 19:49:18 2020 +0000
tree efd42986fa5d30e998bd5e7779ee58e8b0d1b4a6
parent f4aa8cac9f6896a1913f29a5d95822d452be245d

Change Arial font's charset value to CHARSET_FLAG_ANSI for testing.

This CL changes Arial font's charset value to CHARSET_FLAG_ANSI in
CFX_FolderFontInfoTest since Arial is in fact an ANSI font.

Due to this change, Arial is no longer a mock-up symbol font for the
test, and it should no longer be a match for |kSymbol|, of which the
charset value is CHARSET_FLAG_SYMBOL. Therefore, this CL also updates
the expectation for |kSymbol|'s matching font.

Change-Id: Ib8ce8b193dca884926a07024baa7c746f4b7fe48
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/75391
Commit-Queue: Hui Yingst <nigi@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

core/fxge/cfx_folderfontinfo_unittest.cpp

diff --git a/core/fxge/cfx_folderfontinfo_unittest.cpp b/core/fxge/cfx_folderfontinfo_unittest.cpp
index c6b2629..7a1e3d3 100644
--- a/core/fxge/cfx_folderfontinfo_unittest.cpp
+++ b/core/fxge/cfx_folderfontinfo_unittest.cpp
@@ -28,7 +28,7 @@
     auto arial_info = std::make_unique<CFX_FolderFontInfo::FontFaceInfo>(
         /*filePath=*/"", kArial, /*fontTables=*/"",
         /*fontOffset=*/0, /*fileSize=*/0);
-    arial_info->m_Charsets = CHARSET_FLAG_SYMBOL;
+    arial_info->m_Charsets = CHARSET_FLAG_ANSI;
     auto times_new_roman_info =
         std::make_unique<CFX_FolderFontInfo::FontFaceInfo>(
             /*filePath=*/"", kTimesNewRoman, /*fontTables=*/"",
@@ -90,5 +90,5 @@
   font = FindFont(/*weight=*/0, /*bItalic=*/false, FX_CHARSET_Symbol,
                   FXFONT_FF_ROMAN, kSymbol, /*bMatchName=*/false);
   ASSERT_TRUE(font);
-  EXPECT_EQ(GetFaceName(font), kArial);
+  EXPECT_EQ(GetFaceName(font), kBookshelfSymbol7);
 }