commit 327a070e8c22324404819da9e5883bc8bc132013
author Tom Sepez <tsepez@chromium.org> Fri Oct 15 19:38:55 2021 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Oct 15 19:38:55 2021 +0000
tree 6a89836df027274d05eed31b842c997520fa67c2
parent f70d7dbb03125b7cff63f087d8a563df8ea2dd5b

Add final keyword to several classes.

Manual review of output of i.e.
  git grep -L final `git grep -l override *.h `

(I was lamenting the lack of 'final' in an unrelated matter.)

Change-Id: Id8ee4fc2b158ac8604d3fb8a57b711e69d3bd848
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/85951
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

xfa/fde/cfde_texteditengine.h

diff --git a/xfa/fde/cfde_texteditengine.h b/xfa/fde/cfde_texteditengine.h
index 9cd8387..4d9c0c8 100644
--- a/xfa/fde/cfde_texteditengine.h
+++ b/xfa/fde/cfde_texteditengine.h
@@ -38,7 +38,7 @@
     default;
 inline FDE_TEXTEDITPIECE::~FDE_TEXTEDITPIECE() = default;
 
-class CFDE_TextEditEngine : public CFGAS_TxtBreak::Engine {
+class CFDE_TextEditEngine final : public CFGAS_TxtBreak::Engine {
  public:
   class Iterator {
    public:

xfa/fxfa/cxfa_ffapp.h

diff --git a/xfa/fxfa/cxfa_ffapp.h b/xfa/fxfa/cxfa_ffapp.h
index f3a5c75..d26b90c 100644
--- a/xfa/fxfa/cxfa_ffapp.h
+++ b/xfa/fxfa/cxfa_ffapp.h
@@ -21,8 +21,8 @@
 class CXFA_FontMgr;
 class IFX_SeekableReadStream;
 
-class CXFA_FFApp : public cppgc::GarbageCollected<CXFA_FFApp>,
-                   public CFWL_App::AdapterIface {
+class CXFA_FFApp final : public cppgc::GarbageCollected<CXFA_FFApp>,
+                         public CFWL_App::AdapterIface {
  public:
   class CallbackIface {
    public:

xfa/fxfa/cxfa_fwladapterwidgetmgr.h

diff --git a/xfa/fxfa/cxfa_fwladapterwidgetmgr.h b/xfa/fxfa/cxfa_fwladapterwidgetmgr.h
index c3f97dd..c300c35 100644
--- a/xfa/fxfa/cxfa_fwladapterwidgetmgr.h
+++ b/xfa/fxfa/cxfa_fwladapterwidgetmgr.h
@@ -14,7 +14,7 @@
 class CFWL_Widget;
 class CFX_RectF;
 
-class CXFA_FWLAdapterWidgetMgr
+class CXFA_FWLAdapterWidgetMgr final
     : public cppgc::GarbageCollected<CXFA_FWLAdapterWidgetMgr>,
       public CFWL_WidgetMgr::AdapterIface {
  public:

xfa/fxfa/layout/cxfa_layoutprocessor.h

diff --git a/xfa/fxfa/layout/cxfa_layoutprocessor.h b/xfa/fxfa/layout/cxfa_layoutprocessor.h
index 8edefb6..21a8b06 100644
--- a/xfa/fxfa/layout/cxfa_layoutprocessor.h
+++ b/xfa/fxfa/layout/cxfa_layoutprocessor.h
@@ -28,7 +28,7 @@
 class Heap;
 }  // namespace cppgc
 
-class CXFA_LayoutProcessor : public CXFA_Document::LayoutProcessorIface {
+class CXFA_LayoutProcessor final : public CXFA_Document::LayoutProcessorIface {
  public:
   static CXFA_LayoutProcessor* FromDocument(const CXFA_Document* pXFADoc);
 

xfa/fxfa/parser/cxfa_localemgr.h

diff --git a/xfa/fxfa/parser/cxfa_localemgr.h b/xfa/fxfa/parser/cxfa_localemgr.h
index ce739e6..051bfe4 100644
--- a/xfa/fxfa/parser/cxfa_localemgr.h
+++ b/xfa/fxfa/parser/cxfa_localemgr.h
@@ -22,8 +22,8 @@
 class CXFA_NodeLocale;
 class CXFA_XMLLocale;
 
-class CXFA_LocaleMgr : public cppgc::GarbageCollected<CXFA_LocaleMgr>,
-                       public LocaleMgrIface {
+class CXFA_LocaleMgr final : public cppgc::GarbageCollected<CXFA_LocaleMgr>,
+                             public LocaleMgrIface {
  public:
   enum class LangID : uint16_t {
     k_zh_HK = 0x0c04,