commit 3c226cd176f7cf0fb8a3c7d50c5b23d0968c5ed7
author Lei Zhang <thestig@chromium.org> Fri Sep 16 01:33:51 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Sep 16 01:33:51 2022 +0000
tree d68a5a48b83889a862fb42c0298b6ff0709380ad
parent be937bf254521a8990a2e786ea3f1180ea0869ad

Remove dead code in CFX_FileBufferArchive.

The CFX_FileBufferArchive ctor already determined a pointer is non-null.
Assume it is non-null in CFX_FileBufferArchive::Flush().

Change-Id: Ife3bb1bad0209735d35bca2d764163bb0584bc47
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/98071
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

core/fpdfapi/edit/cpdf_creator.cpp

diff --git a/core/fpdfapi/edit/cpdf_creator.cpp b/core/fpdfapi/edit/cpdf_creator.cpp
index 6ae8a00..c7f7424 100644
--- a/core/fpdfapi/edit/cpdf_creator.cpp
+++ b/core/fpdfapi/edit/cpdf_creator.cpp
@@ -50,7 +50,7 @@
   FX_FILESIZE offset_ = 0;
   DataVector<uint8_t> buffer_;
   pdfium::span<uint8_t> available_;
-  RetainPtr<IFX_RetainableWriteStream> backing_file_;
+  RetainPtr<IFX_RetainableWriteStream> const backing_file_;
 };
 
 CFX_FileBufferArchive::CFX_FileBufferArchive(
@@ -68,8 +68,6 @@
 bool CFX_FileBufferArchive::Flush() {
   size_t nUsed = buffer_.size() - available_.size();
   available_ = pdfium::make_span(buffer_);
-  if (!backing_file_)
-    return false;
   if (!nUsed)
     return true;
   return backing_file_->WriteBlock(buffer_.data(), nUsed);