)]}'
{
  "commit": "53783ad97610d218e4e6ce04413e0ef18ee21b7a",
  "tree": "e893bc3f1d25e1742aba48ce49bd95134c2998fe",
  "parents": [
    "bf9243c3e3870fd46f4e2b2e7c670483e17ce8a6"
  ],
  "author": {
    "name": "Tom Sepez",
    "email": "tsepez@chromium.org",
    "time": "Wed Aug 04 20:09:48 2021 +0000"
  },
  "committer": {
    "name": "Pdfium LUCI CQ",
    "email": "pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Wed Aug 04 20:09:48 2021 +0000"
  },
  "message": "Convert OnChar() arguments back to uint32_t\n\nThe CL at https://pdfium-review.googlesource.com/c/pdfium/+/83870\nwas a bit over-zealous in the conversion of the OnChar() methods to\nVKEYCODE. Although we frequently pass VKEYCODES to these methods,\nand compare against VKEYCODES inside these methods, the arguments\nare actually character codes, not key codes. The cross-type\nusages happen to work because we selectively use the only the\nvalues where they are equivalent.\n\nUpdate the test to make the differences in calling clearer.\n\nWe\u0027ll need a subsequent CL to split CFWL_MessageKey into, say,\nCFWL_MessageChar to get complete type correctness, but just\ncast for now.\n\nChange-Id: I5ada6ea2abe124116e3eaa13460cf05e2eb055d8\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/83910\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "369f6ced81b6a542bf23d3b3a91c2f330769bb1a",
      "old_mode": 33188,
      "old_path": "fpdfsdk/cpdfsdk_annothandlermgr.cpp",
      "new_id": "1299c49c1f39a853e016446b117e5c1f3fe30793",
      "new_mode": 33188,
      "new_path": "fpdfsdk/cpdfsdk_annothandlermgr.cpp"
    },
    {
      "type": "modify",
      "old_id": "6c96cc6436e5a648c736e738bd4e005444216a5d",
      "old_mode": 33188,
      "old_path": "fpdfsdk/cpdfsdk_annothandlermgr.h",
      "new_id": "f43a2b9d96e46d0ee470e36c947905defa5828f2",
      "new_mode": 33188,
      "new_path": "fpdfsdk/cpdfsdk_annothandlermgr.h"
    },
    {
      "type": "modify",
      "old_id": "f904cda94771b42febc47543c60c1d821ced9cfb",
      "old_mode": 33188,
      "old_path": "fpdfsdk/cpdfsdk_baannothandler.cpp",
      "new_id": "5ade8d9d121d3ec821086c494442d15b8c43d461",
      "new_mode": 33188,
      "new_path": "fpdfsdk/cpdfsdk_baannothandler.cpp"
    },
    {
      "type": "modify",
      "old_id": "8e10a5af691a9bbd26df5aff11f76baa9958546f",
      "old_mode": 33188,
      "old_path": "fpdfsdk/cpdfsdk_baannothandler.h",
      "new_id": "f5b632a96886834ed3448aacbda1b85b3e26f75f",
      "new_mode": 33188,
      "new_path": "fpdfsdk/cpdfsdk_baannothandler.h"
    },
    {
      "type": "modify",
      "old_id": "fbf0020f1b0ecdc5272ced7868cf06f230eb66dc",
      "old_mode": 33188,
      "old_path": "fpdfsdk/cpdfsdk_pageview.cpp",
      "new_id": "a2648da34da8e2145e44734c59565561902c943c",
      "new_mode": 33188,
      "new_path": "fpdfsdk/cpdfsdk_pageview.cpp"
    },
    {
      "type": "modify",
      "old_id": "fa31e144505bb0e47d3d86bba7ec062305b3790f",
      "old_mode": 33188,
      "old_path": "fpdfsdk/cpdfsdk_pageview.h",
      "new_id": "22197793b51752027e000884fbf17d5c1639926a",
      "new_mode": 33188,
      "new_path": "fpdfsdk/cpdfsdk_pageview.h"
    },
    {
      "type": "modify",
      "old_id": "5c486b9f5c823243f1db6773b1f7e4381657c465",
      "old_mode": 33188,
      "old_path": "fpdfsdk/cpdfsdk_widgethandler.cpp",
      "new_id": "2de83f06e6494479e25a0aa4ee4739451b25c09f",
      "new_mode": 33188,
      "new_path": "fpdfsdk/cpdfsdk_widgethandler.cpp"
    },
    {
      "type": "modify",
      "old_id": "596df121cdfdaabb841e1de80284fc1b70060a81",
      "old_mode": 33188,
      "old_path": "fpdfsdk/cpdfsdk_widgethandler.h",
      "new_id": "366d093005a3f6f212fc17e533f3e03a06cbc59b",
      "new_mode": 33188,
      "new_path": "fpdfsdk/cpdfsdk_widgethandler.h"
    },
    {
      "type": "modify",
      "old_id": "6cf3f90565e7c37ae9de50f17bba1b0cd9450a9d",
      "old_mode": 33188,
      "old_path": "fpdfsdk/fpdf_formfill.cpp",
      "new_id": "5871721b0419372e5f44f301288e96c4141201b2",
      "new_mode": 33188,
      "new_path": "fpdfsdk/fpdf_formfill.cpp"
    },
    {
      "type": "modify",
      "old_id": "2414bc84c9b8461e6962828987d607256831e65b",
      "old_mode": 33188,
      "old_path": "fpdfsdk/fpdf_formfill_embeddertest.cpp",
      "new_id": "817602ad17aa70b1595771899f1a93ef5f98da8c",
      "new_mode": 33188,
      "new_path": "fpdfsdk/fpdf_formfill_embeddertest.cpp"
    },
    {
      "type": "modify",
      "old_id": "ff907d6268bd2dc2b73a2e7e6668756d68565ac6",
      "old_mode": 33188,
      "old_path": "fpdfsdk/fpdfxfa/cpdfxfa_widgethandler.cpp",
      "new_id": "b7bfc3d33f68edbe9c4334d003a0dc149f5189e1",
      "new_mode": 33188,
      "new_path": "fpdfsdk/fpdfxfa/cpdfxfa_widgethandler.cpp"
    },
    {
      "type": "modify",
      "old_id": "7fbc8c18b480285f9afe937d282e5877f525cd86",
      "old_mode": 33188,
      "old_path": "fpdfsdk/fpdfxfa/cpdfxfa_widgethandler.h",
      "new_id": "cd0ed25f59ad53524614b82e78eae28c778ad706",
      "new_mode": 33188,
      "new_path": "fpdfsdk/fpdfxfa/cpdfxfa_widgethandler.h"
    },
    {
      "type": "modify",
      "old_id": "4a41418ec0cf422d04d05669d80543ca80dac670",
      "old_mode": 33188,
      "old_path": "fpdfsdk/ipdfsdk_annothandler.h",
      "new_id": "cd0c7c5416f695f64381893282b5ee03577de1e9",
      "new_mode": 33188,
      "new_path": "fpdfsdk/ipdfsdk_annothandler.h"
    },
    {
      "type": "modify",
      "old_id": "bcf24781097d5f7e79f7e5c6a44a452d17b7b3d2",
      "old_mode": 33188,
      "old_path": "xfa/fwl/cfwl_checkbox.cpp",
      "new_id": "cd912a9eb28b628037db10c794f50b75e5718e60",
      "new_mode": 33188,
      "new_path": "xfa/fwl/cfwl_checkbox.cpp"
    },
    {
      "type": "modify",
      "old_id": "d1e3835edfd94d229ba14f0c8aaa3e2a9bf5af05",
      "old_mode": 33188,
      "old_path": "xfa/fwl/cfwl_combobox.cpp",
      "new_id": "c602b17f11fb6b5bd23c9c7c2f364004bd674ff8",
      "new_mode": 33188,
      "new_path": "xfa/fwl/cfwl_combobox.cpp"
    },
    {
      "type": "modify",
      "old_id": "4191646a5013467b23f5215bc3d18eab8a19ff61",
      "old_mode": 33188,
      "old_path": "xfa/fwl/cfwl_combolist.cpp",
      "new_id": "58252671963d0e94172d574c8c20dfcc86587f3f",
      "new_mode": 33188,
      "new_path": "xfa/fwl/cfwl_combolist.cpp"
    },
    {
      "type": "modify",
      "old_id": "ecb84d1660828510d80620ea232d0cfbee6b84d9",
      "old_mode": 33188,
      "old_path": "xfa/fwl/cfwl_edit.cpp",
      "new_id": "1c3fb9e4a2fbcadb0b18ca96a67404a32eef107c",
      "new_mode": 33188,
      "new_path": "xfa/fwl/cfwl_edit.cpp"
    },
    {
      "type": "modify",
      "old_id": "63081134bc260f361464465a3c9ef225c0a129d5",
      "old_mode": 33188,
      "old_path": "xfa/fwl/cfwl_listbox.cpp",
      "new_id": "1157310a448004d94fad30b99c2fb412618ef613",
      "new_mode": 33188,
      "new_path": "xfa/fwl/cfwl_listbox.cpp"
    },
    {
      "type": "modify",
      "old_id": "dd834a2d86e6a6539fc5603a2601e4ea41b5726a",
      "old_mode": 33188,
      "old_path": "xfa/fwl/cfwl_messagekey.cpp",
      "new_id": "9d5f0531d1aec43b8fb56dda72bc2436cff4d895",
      "new_mode": 33188,
      "new_path": "xfa/fwl/cfwl_messagekey.cpp"
    },
    {
      "type": "modify",
      "old_id": "d469a8c6065461f65c5e06de9450d9d6b1ace287",
      "old_mode": 33188,
      "old_path": "xfa/fwl/cfwl_messagekey.h",
      "new_id": "34dc7d2c085fca00f4d6b6240097229ed714a066",
      "new_mode": 33188,
      "new_path": "xfa/fwl/cfwl_messagekey.h"
    },
    {
      "type": "modify",
      "old_id": "3d22c31e1f4cf78f329cb1d711d55283dd33e30f",
      "old_mode": 33188,
      "old_path": "xfa/fwl/cfwl_notedriver.cpp",
      "new_id": "d2a2059253450b62aad09b1f95c0dad6d24cc0b0",
      "new_mode": 33188,
      "new_path": "xfa/fwl/cfwl_notedriver.cpp"
    },
    {
      "type": "modify",
      "old_id": "67b9cad18df841e532cd58d5e0ef50a5b505fb7a",
      "old_mode": 33188,
      "old_path": "xfa/fwl/cfwl_pushbutton.cpp",
      "new_id": "cb9b9a3aabe62970049c67efc55b7b3263b47bac",
      "new_mode": 33188,
      "new_path": "xfa/fwl/cfwl_pushbutton.cpp"
    },
    {
      "type": "modify",
      "old_id": "010d05e68caab25b671fc789073050c2f37d2030",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/cxfa_fffield.cpp",
      "new_id": "09435354aa23b9de0e05088f1946dd49adf44304",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/cxfa_fffield.cpp"
    },
    {
      "type": "modify",
      "old_id": "0977a6f4db235b593edda19b5db52949acf6208a",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/cxfa_fffield.h",
      "new_id": "55ce4c6c6b964416344dc76ff8cafd7d8c84853d",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/cxfa_fffield.h"
    },
    {
      "type": "modify",
      "old_id": "6b46a4cfa59fed0c324389932e906cb8226a750c",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/cxfa_ffsignature.cpp",
      "new_id": "3e4930ab4fc29d8697b59c3d37d4a86d32f9c485",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/cxfa_ffsignature.cpp"
    },
    {
      "type": "modify",
      "old_id": "122e1b377a5795f29de64ea219a775d565b892f5",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/cxfa_ffsignature.h",
      "new_id": "2fa31fac73cf84b1f721dbdb3d5f83456db5baec",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/cxfa_ffsignature.h"
    },
    {
      "type": "modify",
      "old_id": "3f14c4cc0c3a1651044bc3e65f591d423d0b98d6",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/cxfa_ffwidget.cpp",
      "new_id": "a202280d1e18e4a9f814b58a82ca491e6255e20c",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/cxfa_ffwidget.cpp"
    },
    {
      "type": "modify",
      "old_id": "75f134ea5596ab05aa92df508dd00888012000e1",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/cxfa_ffwidget.h",
      "new_id": "66b8450fac1d1ade2fc44cf8ba718ce78d65705d",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/cxfa_ffwidget.h"
    },
    {
      "type": "modify",
      "old_id": "46461d094b776ec48332a49a4cc6aa3b02d0144e",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/cxfa_ffwidgethandler.cpp",
      "new_id": "4144663468872764f8ff05b2f79aafa49254cce7",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/cxfa_ffwidgethandler.cpp"
    },
    {
      "type": "modify",
      "old_id": "d66db08f6643ea8fe5a14140ba0205ed4760aa25",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/cxfa_ffwidgethandler.h",
      "new_id": "96303a10b2081f3472431ca2ea6b38ee60cd9f2b",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/cxfa_ffwidgethandler.h"
    }
  ]
}