commit 599507d26d995f011145b2f2643fa447ab1e4347
author Lei Zhang <thestig@chromium.org> Wed Sep 06 21:10:38 2023 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Sep 06 21:10:38 2023 +0000
tree ecefa7335e1036975beb291585376005bc47924b
parent 6ea677caeb7817940756da328059a60a8f8fec8e

Add a test to show import APIs do not work for docs without Info dicts

Bug: pdfium:2049
Change-Id: I740ee68e1f4a8042bf57fbe7226b14cc6b90d8f7
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/111615
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

fpdfsdk/fpdf_ppo_embeddertest.cpp

diff --git a/fpdfsdk/fpdf_ppo_embeddertest.cpp b/fpdfsdk/fpdf_ppo_embeddertest.cpp
index 73e8246..12e4d5e 100644
--- a/fpdfsdk/fpdf_ppo_embeddertest.cpp
+++ b/fpdfsdk/fpdf_ppo_embeddertest.cpp
@@ -3,6 +3,8 @@
 // found in the LICENSE file.
 
 #include <iterator>
+#include <memory>
+#include <string>
 
 #include "core/fpdfapi/page/cpdf_form.h"
 #include "core/fpdfapi/page/cpdf_formobject.h"
@@ -23,6 +25,8 @@
 #include "testing/embedder_test.h"
 #include "testing/embedder_test_constants.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "testing/utils/file_util.h"
+#include "testing/utils/path_service.h"
 
 namespace {
 
@@ -622,3 +626,27 @@
   ScopedFPDFBitmap new_bitmap = RenderPage(new_page.get());
   CompareBitmap(new_bitmap.get(), 200, 200, pdfium::HelloWorldChecksum());
 }
+
+TEST_F(FPDFPPOEmbedderTest, ImportIntoDestDocWithoutInfo) {
+  ASSERT_TRUE(OpenDocument("hello_world.pdf"));
+  EXPECT_EQ(1, FPDF_GetPageCount(document()));
+
+  std::string file_path;
+  ASSERT_TRUE(PathService::GetTestFilePath("rectangles.pdf", &file_path));
+  size_t file_length = 0;
+  std::unique_ptr<char, pdfium::FreeDeleter> file_contents =
+      GetFileContents(file_path.c_str(), &file_length);
+  DCHECK(file_contents);
+  ScopedFPDFDocument src_doc(
+      FPDF_LoadMemDocument(file_contents.get(), file_length, nullptr));
+  ASSERT_TRUE(src_doc);
+
+  // TODO(crbug.com/pdfium/2049): The import should succeed.
+  static constexpr int kIndices[] = {0};
+  EXPECT_FALSE(FPDF_ImportPagesByIndex(document(), src_doc.get(), kIndices,
+                                       std::size(kIndices), 0));
+  EXPECT_EQ(1, FPDF_GetPageCount(document()));
+
+  EXPECT_FALSE(FPDF_ImportPages(document(), src_doc.get(), "1", 0));
+  EXPECT_EQ(1, FPDF_GetPageCount(document()));
+}