Remove dead code in CPDFSDK_ActionHandler.
Change-Id: I04055d25268ec71b44b5139aaa5c7fdf4292ce83
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/57855
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
diff --git a/fpdfsdk/cpdfsdk_actionhandler.cpp b/fpdfsdk/cpdfsdk_actionhandler.cpp
index 196904d..b8a50c4 100644
--- a/fpdfsdk/cpdfsdk_actionhandler.cpp
+++ b/fpdfsdk/cpdfsdk_actionhandler.cpp
@@ -75,32 +75,6 @@
return ExecuteDocumentPageAction(action, eType, pFormFillEnv, &visited);
}
-bool CPDFSDK_ActionHandler::DoAction_BookMark(
- CPDF_Bookmark* pBookMark,
- const CPDF_Action& action,
- CPDF_AAction::AActionType type,
- CPDFSDK_FormFillEnvironment* pFormFillEnv) {
- std::set<const CPDF_Dictionary*> visited;
- return ExecuteBookMark(action, type, pFormFillEnv, pBookMark, &visited);
-}
-
-bool CPDFSDK_ActionHandler::DoAction_Screen(
- const CPDF_Action& action,
- CPDF_AAction::AActionType type,
- CPDFSDK_FormFillEnvironment* pFormFillEnv,
- CPDFSDK_Annot* pScreen) {
- std::set<const CPDF_Dictionary*> visited;
- return ExecuteScreenAction(action, type, pFormFillEnv, pScreen, &visited);
-}
-
-bool CPDFSDK_ActionHandler::DoAction_Link(
- const CPDF_Action& action,
- CPDF_AAction::AActionType type,
- CPDFSDK_FormFillEnvironment* pFormFillEnv) {
- std::set<const CPDF_Dictionary*> visited;
- return ExecuteLinkAction(action, type, pFormFillEnv, &visited);
-}
-
bool CPDFSDK_ActionHandler::DoAction_Field(
const CPDF_Action& action,
CPDF_AAction::AActionType type,
@@ -143,36 +117,6 @@
return true;
}
-bool CPDFSDK_ActionHandler::ExecuteLinkAction(
- const CPDF_Action& action,
- CPDF_AAction::AActionType eType,
- CPDFSDK_FormFillEnvironment* pFormFillEnv,
- std::set<const CPDF_Dictionary*>* visited) {
- const CPDF_Dictionary* pDict = action.GetDict();
- if (pdfium::ContainsKey(*visited, pDict))
- return false;
-
- visited->insert(pDict);
-
- ASSERT(pFormFillEnv);
- if (action.GetType() == CPDF_Action::JavaScript) {
- RunScriptForAction(action, pFormFillEnv,
- [pFormFillEnv](IJS_EventContext* context) {
- context->OnLink_MouseUp(pFormFillEnv);
- });
- } else {
- DoAction_NoJs(action, eType, pFormFillEnv);
- }
-
- for (int32_t i = 0, sz = action.GetSubActionsCount(); i < sz; i++) {
- CPDF_Action subaction = action.GetSubAction(i);
- if (!ExecuteLinkAction(subaction, eType, pFormFillEnv, visited))
- return false;
- }
-
- return true;
-}
-
bool CPDFSDK_ActionHandler::ExecuteDocumentPageAction(
const CPDF_Action& action,
CPDF_AAction::AActionType type,
@@ -253,64 +197,6 @@
return true;
}
-bool CPDFSDK_ActionHandler::ExecuteScreenAction(
- const CPDF_Action& action,
- CPDF_AAction::AActionType type,
- CPDFSDK_FormFillEnvironment* pFormFillEnv,
- CPDFSDK_Annot* pScreen,
- std::set<const CPDF_Dictionary*>* visited) {
- const CPDF_Dictionary* pDict = action.GetDict();
- if (pdfium::ContainsKey(*visited, pDict))
- return false;
-
- visited->insert(pDict);
-
- ASSERT(pFormFillEnv);
- if (action.GetType() == CPDF_Action::JavaScript)
- RunScriptForAction(action, pFormFillEnv, [](IJS_EventContext*) {});
- else
- DoAction_NoJs(action, type, pFormFillEnv);
-
- for (int32_t i = 0, sz = action.GetSubActionsCount(); i < sz; i++) {
- CPDF_Action subaction = action.GetSubAction(i);
- if (!ExecuteScreenAction(subaction, type, pFormFillEnv, pScreen, visited))
- return false;
- }
-
- return true;
-}
-
-bool CPDFSDK_ActionHandler::ExecuteBookMark(
- const CPDF_Action& action,
- CPDF_AAction::AActionType type,
- CPDFSDK_FormFillEnvironment* pFormFillEnv,
- CPDF_Bookmark* pBookmark,
- std::set<const CPDF_Dictionary*>* visited) {
- const CPDF_Dictionary* pDict = action.GetDict();
- if (pdfium::ContainsKey(*visited, pDict))
- return false;
-
- visited->insert(pDict);
-
- ASSERT(pFormFillEnv);
- if (action.GetType() == CPDF_Action::JavaScript) {
- RunScriptForAction(action, pFormFillEnv,
- [pBookmark](IJS_EventContext* context) {
- context->OnBookmark_MouseUp(pBookmark);
- });
- } else {
- DoAction_NoJs(action, type, pFormFillEnv);
- }
-
- for (int32_t i = 0, sz = action.GetSubActionsCount(); i < sz; i++) {
- CPDF_Action subaction = action.GetSubAction(i);
- if (!ExecuteBookMark(subaction, type, pFormFillEnv, pBookmark, visited))
- return false;
- }
-
- return true;
-}
-
void CPDFSDK_ActionHandler::DoAction_NoJs(
const CPDF_Action& action,
CPDF_AAction::AActionType type,
@@ -530,20 +416,6 @@
pForm->DoAction_ResetForm(action);
}
-void CPDFSDK_ActionHandler::RunScriptForAction(
- const CPDF_Action& action,
- CPDFSDK_FormFillEnvironment* pFormFillEnv,
- const RunScriptCallback& cb) {
- if (!pFormFillEnv->IsJSPlatformPresent())
- return;
-
- WideString swJS = action.GetJavaScript();
- if (swJS.IsEmpty())
- return;
-
- RunScript(pFormFillEnv, swJS, cb);
-}
-
void CPDFSDK_ActionHandler::RunScript(CPDFSDK_FormFillEnvironment* pFormFillEnv,
const WideString& script,
const RunScriptCallback& cb) {
diff --git a/fpdfsdk/cpdfsdk_actionhandler.h b/fpdfsdk/cpdfsdk_actionhandler.h
index 94b347f..a8bd9cf 100644
--- a/fpdfsdk/cpdfsdk_actionhandler.h
+++ b/fpdfsdk/cpdfsdk_actionhandler.h
@@ -17,7 +17,6 @@
class CPDFSDK_Annot;
class CPDFSDK_FormFillEnvironment;
-class CPDF_Bookmark;
class CPDF_Dictionary;
class CPDF_FormField;
class IJS_EventContext;
@@ -35,17 +34,6 @@
bool DoAction_Document(const CPDF_Action& action,
enum CPDF_AAction::AActionType eType,
CPDFSDK_FormFillEnvironment* pFormFillEnv);
- bool DoAction_BookMark(CPDF_Bookmark* pBookMark,
- const CPDF_Action& action,
- CPDF_AAction::AActionType type,
- CPDFSDK_FormFillEnvironment* pFormFillEnv);
- bool DoAction_Screen(const CPDF_Action& action,
- CPDF_AAction::AActionType type,
- CPDFSDK_FormFillEnvironment* pFormFillEnv,
- CPDFSDK_Annot* pScreen);
- bool DoAction_Link(const CPDF_Action& action,
- CPDF_AAction::AActionType type,
- CPDFSDK_FormFillEnvironment* pFormFillEnv);
bool DoAction_Field(const CPDF_Action& action,
CPDF_AAction::AActionType type,
CPDFSDK_FormFillEnvironment* pFormFillEnv,
@@ -60,9 +48,6 @@
private:
using RunScriptCallback = std::function<void(IJS_EventContext* context)>;
- void RunScriptForAction(const CPDF_Action& action,
- CPDFSDK_FormFillEnvironment* pFormFillEnv,
- const RunScriptCallback& cb);
void RunScript(CPDFSDK_FormFillEnvironment* pFormFillEnv,
const WideString& script,
const RunScriptCallback& cb);
@@ -80,20 +65,6 @@
CPDF_FormField* pFormField,
CPDFSDK_FieldAction* data,
std::set<const CPDF_Dictionary*>* visited);
- bool ExecuteScreenAction(const CPDF_Action& action,
- CPDF_AAction::AActionType type,
- CPDFSDK_FormFillEnvironment* pFormFillEnv,
- CPDFSDK_Annot* pScreen,
- std::set<const CPDF_Dictionary*>* visited);
- bool ExecuteBookMark(const CPDF_Action& action,
- CPDF_AAction::AActionType type,
- CPDFSDK_FormFillEnvironment* pFormFillEnv,
- CPDF_Bookmark* pBookmark,
- std::set<const CPDF_Dictionary*>* visited);
- bool ExecuteLinkAction(const CPDF_Action& action,
- CPDF_AAction::AActionType type,
- CPDFSDK_FormFillEnvironment* pFormFillEnv,
- std::set<const CPDF_Dictionary*>* visited);
void DoAction_NoJs(const CPDF_Action& action,
CPDF_AAction::AActionType type,