commit 65bdd36da8810dd698bb5195b519097d1d2b9f65
author Hui Yingst <nigi@chromium.org> Tue May 05 00:03:29 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Tue May 05 00:03:29 2020 +0000
tree 3b4634d9c723d5b4b6054afdb05bbd828fe945a5
parent 8a5765baabe21ff2c934e94626cc0b2771fc7049

Fix FPDFFormFillEmbedderTest.RemoveFormFieldHighlight for Skia.

Skia uses different font face rendering methods compared to AGG, which
leads to the text rendering discrepancy for Helvetica font in this test
(See https://crbug.com/pdfium/1500#c7).

Since Skia's rendering results are acceptable and Skia is working as
intended, this CL adds expected results for Skia to make this embedder
test pass.

Bug: pdfium:1500
Change-Id: If83966419172971b36327bb8d6282fb44e96018f
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/69510
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Hui Yingst <nigi@chromium.org>

fpdfsdk/fpdf_formfill_embeddertest.cpp

diff --git a/fpdfsdk/fpdf_formfill_embeddertest.cpp b/fpdfsdk/fpdf_formfill_embeddertest.cpp
index 03d9c22..174e9c1 100644
--- a/fpdfsdk/fpdf_formfill_embeddertest.cpp
+++ b/fpdfsdk/fpdf_formfill_embeddertest.cpp
@@ -1351,12 +1351,10 @@
   UnloadPage(page);
 }
 
+TEST_F(FPDFFormFillEmbedderTest, RemoveFormFieldHighlight) {
 #if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
-#define MAYBE_RemoveFormFieldHighlight DISABLED_RemoveFormFieldHighlight
+  const char kMd5NoHighlight[] = "6fe3921e4fe3f4190c248acf34e9bd3b";
 #else
-#define MAYBE_RemoveFormFieldHighlight RemoveFormFieldHighlight
-#endif
-TEST_F(FPDFFormFillEmbedderTest, MAYBE_RemoveFormFieldHighlight) {
 #if defined(OS_MACOSX)
   const char kMd5NoHighlight[] = "5e4b87c5b304c6fa9bd5f6311260494e";
 #elif defined(OS_WIN)
@@ -1364,6 +1362,7 @@
 #else
   const char kMd5NoHighlight[] = "006010c318457810a518aa5e0b33c498";
 #endif
+#endif  // defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
 
   EXPECT_TRUE(OpenDocument("text_form.pdf"));
   FPDF_PAGE page = LoadPage(0);