commit 698283cd525e8de0f80e9317c5ec64164a6c0d1c
author Lei Zhang <thestig@chromium.org> Wed Feb 05 13:21:52 2025 -0800
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Feb 05 13:21:52 2025 -0800
tree ba08e0ad9b21fcd729e04d19ce9f8e23b8cba015
parent c5a1750519dcc540a7bbd5ccc133ef9e5b9facb5

Test more WideString inputs with StringTo{Float,Double}()

Add coverage to show what happens when the input has a mix of digits and
non-ASCII characters.

Change-Id: I3e88e9371816a4bf6e7e2152f03e460033cedbba
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/128450
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Thomas Sepez <tsepez@google.com>
Commit-Queue: Lei Zhang <thestig@chromium.org>

core/fxcrt/fx_string_unittest.cpp

diff --git a/core/fxcrt/fx_string_unittest.cpp b/core/fxcrt/fx_string_unittest.cpp
index a6037d4..96ccb3c 100644
--- a/core/fxcrt/fx_string_unittest.cpp
+++ b/core/fxcrt/fx_string_unittest.cpp
@@ -182,6 +182,8 @@
                   StringToFloat(L"-999999999999999999999999999999999999999"));
 
   EXPECT_FLOAT_EQ(0.0f, StringToFloat(L"invalid"));
+  EXPECT_FLOAT_EQ(123.0f, StringToFloat(L"123\x3132\x6162.5"));
+  EXPECT_FLOAT_EQ(0.0f, StringToFloat(L"🎨987"));
 
   // Test the exact float value. Use EXPECT_EQ, which does an exact comparison,
   // instead of EXPECT_FLOAT_EQ, which allows slight precision error.
@@ -282,6 +284,8 @@
           L"999999999999999999999999999999999999999999"));
 
   EXPECT_DOUBLE_EQ(0.0, StringToDouble(L"invalid"));
+  EXPECT_FLOAT_EQ(123.0, StringToDouble(L"123\x3132\x6162.5"));
+  EXPECT_FLOAT_EQ(0.0, StringToDouble(L"🎨987"));
 
   // Test the exact double value. Use EXPECT_EQ, which does an exact comparison,
   // instead of EXPECT_DOUBLE_EQ, which allows slight precision error.