commit 6a97b489c9fd0d2f01eb664f12359a0d0e81d410
author Lukasz Anforowicz <lukasza@google.com> Mon Sep 22 15:33:29 2025 -0700
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Sep 22 15:33:29 2025 -0700
tree 8a931bf1d3fa49a671fce148d340d90fdd9eb770
parent df1a79e3e4ee5af67aa6f6039bed9301236fee28

[rust png] Stop building code behind `PNG_pHYs_SUPPORTED` flag.

This macro definition doesn't seem to be defined anywhere in Chromium
nor PDFium.  Let's therefore try to remove code gated behind this flag.

Bug: 444045690
Change-Id: I5bf01d4534e1f2dc1e22d578962f95d9fadf99dd
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/135930
Auto-Submit: Łukasz Anforowicz <lukasza@google.com>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

core/fxcodec/png/png_decoder.cpp

diff --git a/core/fxcodec/png/png_decoder.cpp b/core/fxcodec/png/png_decoder.cpp
index 60a70a2..e1d66d0 100644
--- a/core/fxcodec/png/png_decoder.cpp
+++ b/core/fxcodec/png/png_decoder.cpp
@@ -58,18 +58,11 @@
                              CFX_DIBAttribute* pAttribute) {
   if (pAttribute) {
 #if defined(PNG_pHYs_SUPPORTED)
-    pAttribute->x_dpi_ = png_get_x_pixels_per_meter(png_ptr, info_ptr);
-    pAttribute->y_dpi_ = png_get_y_pixels_per_meter(png_ptr, info_ptr);
-    png_uint_32 res_x, res_y;
-    int unit_type;
-    png_get_pHYs(png_ptr, info_ptr, &res_x, &res_y, &unit_type);
-    switch (unit_type) {
-      case PNG_RESOLUTION_METER:
-        pAttribute->dpi_unit_ = CFX_DIBAttribute::kResUnitMeter;
-        break;
-      default:
-        pAttribute->dpi_unit_ = CFX_DIBAttribute::kResUnitNone;
-    }
+// TODO(https://crbug.com/444045690): If the `#error` below sticks for a few
+// days without causing build errors in the current PDFium clients, then we
+// should be able to go ahead and remove the `pAttribute` parameter here and
+// from `PngDecoder::ContinueDecode`.
+#error PNG_pHYs_SUPPORTED seemed undefined in all known Pdfium clients.
 #endif
 #if defined(PNG_iCCP_SUPPORTED)
     png_charp icc_name;