commit 6e3474279e374ea827715835a7619a5446df5297
author Tom Sepez <tsepez@chromium.org> Thu Feb 20 18:37:13 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Thu Feb 20 18:37:13 2020 +0000
tree 5f078fdaf3d288861eccdf7f9b5c1fb4c6ef44d6
parent 7695440d22982716e700927d01ee8ecbef3278fd

Initialize CFX_BreakPiece members in header.

Then default the constructor implementation to show that there's
no funny business going on.

Change-Id: Ie0d670f1e10bd4811311cb660ebc4cd47e9a9fe1
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66790
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

xfa/fgas/layout/cfx_breakpiece.cpp

diff --git a/xfa/fgas/layout/cfx_breakpiece.cpp b/xfa/fgas/layout/cfx_breakpiece.cpp
index b0cc754..dbdcf6e 100644
--- a/xfa/fgas/layout/cfx_breakpiece.cpp
+++ b/xfa/fgas/layout/cfx_breakpiece.cpp
@@ -8,20 +8,7 @@
 
 #include "xfa/fgas/layout/cfx_textuserdata.h"
 
-CFX_BreakPiece::CFX_BreakPiece()
-    : m_dwStatus(CFX_BreakType::Piece),
-      m_iStartPos(0),
-      m_iWidth(-1),
-      m_iStartChar(0),
-      m_iChars(0),
-      m_iBidiLevel(0),
-      m_iBidiPos(0),
-      m_iFontSize(0),
-      m_iHorizontalScale(100),
-      m_iVerticalScale(100),
-      m_dwIdentity(0),
-      m_dwCharStyles(0),
-      m_pChars(nullptr) {}
+CFX_BreakPiece::CFX_BreakPiece() = default;
 
 CFX_BreakPiece::CFX_BreakPiece(const CFX_BreakPiece& other) = default;
 

xfa/fgas/layout/cfx_breakpiece.h

diff --git a/xfa/fgas/layout/cfx_breakpiece.h b/xfa/fgas/layout/cfx_breakpiece.h
index 8ea7032..303b5db 100644
--- a/xfa/fgas/layout/cfx_breakpiece.h
+++ b/xfa/fgas/layout/cfx_breakpiece.h
@@ -29,18 +29,18 @@
   WideString GetString() const;
   std::vector<int32_t> GetWidths() const;
 
-  CFX_BreakType m_dwStatus;
-  int32_t m_iStartPos;
-  int32_t m_iWidth;
-  int32_t m_iStartChar;
-  int32_t m_iChars;
-  int32_t m_iBidiLevel;
-  int32_t m_iBidiPos;
-  int32_t m_iFontSize;
-  int32_t m_iHorizontalScale;
-  int32_t m_iVerticalScale;
-  uint32_t m_dwIdentity;
-  uint32_t m_dwCharStyles;
+  CFX_BreakType m_dwStatus = CFX_BreakType::Piece;
+  int32_t m_iStartPos = 0;
+  int32_t m_iWidth = -1;
+  int32_t m_iStartChar = 0;
+  int32_t m_iChars = 0;
+  int32_t m_iBidiLevel = 0;
+  int32_t m_iBidiPos = 0;
+  int32_t m_iFontSize = 0;
+  int32_t m_iHorizontalScale = 100;
+  int32_t m_iVerticalScale = 100;
+  uint32_t m_dwIdentity = 0;
+  uint32_t m_dwCharStyles = 0;
   UnownedPtr<std::vector<CFX_Char>> m_pChars;
   RetainPtr<CFX_TextUserData> m_pUserData;
 };