)]}'
{
  "commit": "6fe32f898af3eea875fd01a6d18f719d17dd72f3",
  "tree": "f63a1a03d3fffc3e4e765442df9805b526660765",
  "parents": [
    "ed7da31f67e93c8923669ad496126aa005a8d3a2"
  ],
  "author": {
    "name": "Tom Sepez",
    "email": "tsepez@chromium.org",
    "time": "Thu Oct 25 23:25:58 2018 +0000"
  },
  "committer": {
    "name": "Chromium commit bot",
    "email": "commit-bot@chromium.org",
    "time": "Thu Oct 25 23:25:58 2018 +0000"
  },
  "message": "Make CPWL_Wnd own its pAttachedData.\n\nThis requires moving it out of CreateParams, since that must be\na copyable struct, and implies that currently there is some\nquestionable sharing going on. To resolve this, introduce a\nClone() method so that each window gets its own copy.\n\nMake GetAttachedData() return a const pointer, so that callers\ncan\u0027t free it behind our back.\n\nTidy initializations along the way.\n\nChange-Id: Iadc97688b4692bf4fafefe8cff88af88672f7110\nReviewed-on: https://pdfium-review.googlesource.com/c/44590\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "ac55125db27ad2955ff2c343499b51321821ad75",
      "old_mode": 33188,
      "old_path": "fpdfsdk/formfiller/cffl_checkbox.cpp",
      "new_id": "1127d8f258dd4d88882c572dd8ae6bdab3fc40bd",
      "new_mode": 33188,
      "new_path": "fpdfsdk/formfiller/cffl_checkbox.cpp"
    },
    {
      "type": "modify",
      "old_id": "2eae22273a31e1fdc7608d5ba4c5ff35257d8d4e",
      "old_mode": 33188,
      "old_path": "fpdfsdk/formfiller/cffl_checkbox.h",
      "new_id": "a8fe316356411a18f431976df9f965b094a41bb1",
      "new_mode": 33188,
      "new_path": "fpdfsdk/formfiller/cffl_checkbox.h"
    },
    {
      "type": "modify",
      "old_id": "69cc66bbc804f554131d127372f4636fef4f255e",
      "old_mode": 33188,
      "old_path": "fpdfsdk/formfiller/cffl_combobox.cpp",
      "new_id": "460fdce7ec9678d19b8d61b5db4055ff37765e87",
      "new_mode": 33188,
      "new_path": "fpdfsdk/formfiller/cffl_combobox.cpp"
    },
    {
      "type": "modify",
      "old_id": "4ec5a9ec0cb10edebf0dc2b8341313221705d912",
      "old_mode": 33188,
      "old_path": "fpdfsdk/formfiller/cffl_combobox.h",
      "new_id": "66cd55c3e61432e610cd1b13595b9ed817228b8e",
      "new_mode": 33188,
      "new_path": "fpdfsdk/formfiller/cffl_combobox.h"
    },
    {
      "type": "modify",
      "old_id": "8e9d0c7d6510b2665829dbb5eed11353b9501a33",
      "old_mode": 33188,
      "old_path": "fpdfsdk/formfiller/cffl_formfiller.cpp",
      "new_id": "dace98a8c1f39d42a5b92c6b5da80f4b0bab4a27",
      "new_mode": 33188,
      "new_path": "fpdfsdk/formfiller/cffl_formfiller.cpp"
    },
    {
      "type": "modify",
      "old_id": "a6f7cdc78fb0cbc51d5bc27323f50b5a369108d4",
      "old_mode": 33188,
      "old_path": "fpdfsdk/formfiller/cffl_formfiller.h",
      "new_id": "6b04e0c936366d3dc0be93ea96d576215341f35d",
      "new_mode": 33188,
      "new_path": "fpdfsdk/formfiller/cffl_formfiller.h"
    },
    {
      "type": "modify",
      "old_id": "c712610dcc4abd59acff9ae3c3ea1af6080a5da3",
      "old_mode": 33188,
      "old_path": "fpdfsdk/formfiller/cffl_interactiveformfiller.cpp",
      "new_id": "b578a440b7d48b3c827b35a7464f3eb3027270eb",
      "new_mode": 33188,
      "new_path": "fpdfsdk/formfiller/cffl_interactiveformfiller.cpp"
    },
    {
      "type": "modify",
      "old_id": "bf9fa3c09c370c6ce37cea0a547a7c98e247acb1",
      "old_mode": 33188,
      "old_path": "fpdfsdk/formfiller/cffl_interactiveformfiller.h",
      "new_id": "f4c24e3f564775ae0d430aa1d5cd6b9fec0afb17",
      "new_mode": 33188,
      "new_path": "fpdfsdk/formfiller/cffl_interactiveformfiller.h"
    },
    {
      "type": "modify",
      "old_id": "3c74875d4309a503f35809d368ae292d25d1520a",
      "old_mode": 33188,
      "old_path": "fpdfsdk/formfiller/cffl_listbox.cpp",
      "new_id": "88414cc9fc61fda1b3e3f7d00f66aadfefcbc0e4",
      "new_mode": 33188,
      "new_path": "fpdfsdk/formfiller/cffl_listbox.cpp"
    },
    {
      "type": "modify",
      "old_id": "eed542fde56f6abc73e95b900622e18db6046115",
      "old_mode": 33188,
      "old_path": "fpdfsdk/formfiller/cffl_listbox.h",
      "new_id": "ab4005f7ec5833847ec3c0360e8292f6e05b2ae9",
      "new_mode": 33188,
      "new_path": "fpdfsdk/formfiller/cffl_listbox.h"
    },
    {
      "type": "modify",
      "old_id": "b57c9114864065a86eb8d08705e3da84e9d860e1",
      "old_mode": 33188,
      "old_path": "fpdfsdk/formfiller/cffl_pushbutton.cpp",
      "new_id": "76719d95c8fa39bc7f91de8bd5c7a1fed8b8b0b7",
      "new_mode": 33188,
      "new_path": "fpdfsdk/formfiller/cffl_pushbutton.cpp"
    },
    {
      "type": "modify",
      "old_id": "cc2ff891847fbc58c6f12d0b47b9b26d5e84f729",
      "old_mode": 33188,
      "old_path": "fpdfsdk/formfiller/cffl_pushbutton.h",
      "new_id": "f10dd67f2975abe0948b3c5fc7d70d4db9024ed5",
      "new_mode": 33188,
      "new_path": "fpdfsdk/formfiller/cffl_pushbutton.h"
    },
    {
      "type": "modify",
      "old_id": "6ce4a0aedc25fa6a76b1dcd52cac1aa670eeaea7",
      "old_mode": 33188,
      "old_path": "fpdfsdk/formfiller/cffl_radiobutton.cpp",
      "new_id": "4ae80d6a77c51367df4bfeb467b46157d25690f4",
      "new_mode": 33188,
      "new_path": "fpdfsdk/formfiller/cffl_radiobutton.cpp"
    },
    {
      "type": "modify",
      "old_id": "4702a27aec96ac84e662a2fd752ef35d776bfbb5",
      "old_mode": 33188,
      "old_path": "fpdfsdk/formfiller/cffl_radiobutton.h",
      "new_id": "00769191447dc3766d2192b6af5663e22885ad36",
      "new_mode": 33188,
      "new_path": "fpdfsdk/formfiller/cffl_radiobutton.h"
    },
    {
      "type": "modify",
      "old_id": "ae3cb06e994b9ef9306db73b1f4157932bf79d73",
      "old_mode": 33188,
      "old_path": "fpdfsdk/formfiller/cffl_textfield.cpp",
      "new_id": "e3cde98c82307616ee1f2cc7a98490118d99e02f",
      "new_mode": 33188,
      "new_path": "fpdfsdk/formfiller/cffl_textfield.cpp"
    },
    {
      "type": "modify",
      "old_id": "3be00959e433f59052296071cc05524498689d14",
      "old_mode": 33188,
      "old_path": "fpdfsdk/formfiller/cffl_textfield.h",
      "new_id": "1ba0e6399f2f08972635d9d7bd342805b147adfb",
      "new_mode": 33188,
      "new_path": "fpdfsdk/formfiller/cffl_textfield.h"
    },
    {
      "type": "modify",
      "old_id": "d57619e82fe0e5895245e88a0f016e37c56a5479",
      "old_mode": 33188,
      "old_path": "fpdfsdk/pwl/cpwl_appstream.cpp",
      "new_id": "ebd47befc01a3fc60774af5de00e18387e8b7af1",
      "new_mode": 33188,
      "new_path": "fpdfsdk/pwl/cpwl_appstream.cpp"
    },
    {
      "type": "modify",
      "old_id": "bdf56a21ae00c0b14c81e8c5b8be44cc8cf84347",
      "old_mode": 33188,
      "old_path": "fpdfsdk/pwl/cpwl_button.cpp",
      "new_id": "766e8c49ad48ff6a82eeb8eec03b967eae0d5813",
      "new_mode": 33188,
      "new_path": "fpdfsdk/pwl/cpwl_button.cpp"
    },
    {
      "type": "modify",
      "old_id": "b327371c7ff7e4bfa778e48b4eeff6947a9f3e68",
      "old_mode": 33188,
      "old_path": "fpdfsdk/pwl/cpwl_button.h",
      "new_id": "cf53ff906c63d55ba50dd17fb9e1ddd118d6c967",
      "new_mode": 33188,
      "new_path": "fpdfsdk/pwl/cpwl_button.h"
    },
    {
      "type": "modify",
      "old_id": "24ecb17533c98662d5ce4d19bcbbb38c7b0c22d5",
      "old_mode": 33188,
      "old_path": "fpdfsdk/pwl/cpwl_caret.cpp",
      "new_id": "63fb1ce2b5cb62c263f5e953c8c2b9c3254e050e",
      "new_mode": 33188,
      "new_path": "fpdfsdk/pwl/cpwl_caret.cpp"
    },
    {
      "type": "modify",
      "old_id": "27418ec86853a39efa3b055ceaf563d406c84bcf",
      "old_mode": 33188,
      "old_path": "fpdfsdk/pwl/cpwl_caret.h",
      "new_id": "c85a8776f366ca9322b50d4ae076b9e446d3096a",
      "new_mode": 33188,
      "new_path": "fpdfsdk/pwl/cpwl_caret.h"
    },
    {
      "type": "modify",
      "old_id": "341bd93e41f89b5712f938e64732fc3ea2b62df8",
      "old_mode": 33188,
      "old_path": "fpdfsdk/pwl/cpwl_combo_box.cpp",
      "new_id": "bb5890b519d9db9d7bf8d36939c5b891864d4805",
      "new_mode": 33188,
      "new_path": "fpdfsdk/pwl/cpwl_combo_box.cpp"
    },
    {
      "type": "modify",
      "old_id": "2e66b515b0db016aa074df15bb57ce3b0d2fb245",
      "old_mode": 33188,
      "old_path": "fpdfsdk/pwl/cpwl_combo_box.h",
      "new_id": "e3a3ff38ca929909ee230541663d151985aa7767",
      "new_mode": 33188,
      "new_path": "fpdfsdk/pwl/cpwl_combo_box.h"
    },
    {
      "type": "modify",
      "old_id": "c3a5797304fccb83714fe826163cb0ed696b2e09",
      "old_mode": 33188,
      "old_path": "fpdfsdk/pwl/cpwl_edit.cpp",
      "new_id": "d0922cdf0da5ff6b0c7226240dc4cb81ac0a2109",
      "new_mode": 33188,
      "new_path": "fpdfsdk/pwl/cpwl_edit.cpp"
    },
    {
      "type": "modify",
      "old_id": "d890834aac533ad772cc9f1a0640b998d5a28b8f",
      "old_mode": 33188,
      "old_path": "fpdfsdk/pwl/cpwl_edit.h",
      "new_id": "c996437dd1513fafa0878046231fce39b129c347",
      "new_mode": 33188,
      "new_path": "fpdfsdk/pwl/cpwl_edit.h"
    },
    {
      "type": "modify",
      "old_id": "33a83cc34994e7deb92bff5e8404d468c45f2411",
      "old_mode": 33188,
      "old_path": "fpdfsdk/pwl/cpwl_edit_ctrl.cpp",
      "new_id": "d27c6cd604a5735b668db37f6b9880e4fe5587f2",
      "new_mode": 33188,
      "new_path": "fpdfsdk/pwl/cpwl_edit_ctrl.cpp"
    },
    {
      "type": "modify",
      "old_id": "741ce9c6682fbe90643b628c5005dbee51e2e10b",
      "old_mode": 33188,
      "old_path": "fpdfsdk/pwl/cpwl_edit_ctrl.h",
      "new_id": "eb8ccb802991b18c50e979397afe8d25a429e886",
      "new_mode": 33188,
      "new_path": "fpdfsdk/pwl/cpwl_edit_ctrl.h"
    },
    {
      "type": "modify",
      "old_id": "407e86676626ba9a60fb043c081401035d6b97b4",
      "old_mode": 33188,
      "old_path": "fpdfsdk/pwl/cpwl_icon.cpp",
      "new_id": "8d672f58da55e98e55f431c04a538c99476e93e5",
      "new_mode": 33188,
      "new_path": "fpdfsdk/pwl/cpwl_icon.cpp"
    },
    {
      "type": "modify",
      "old_id": "2cb84ebcf6e6219d8ed7b3093888ae3979682d49",
      "old_mode": 33188,
      "old_path": "fpdfsdk/pwl/cpwl_icon.h",
      "new_id": "83709f7e18bfd3fadf0fd2a7c124ba7a4cb67214",
      "new_mode": 33188,
      "new_path": "fpdfsdk/pwl/cpwl_icon.h"
    },
    {
      "type": "modify",
      "old_id": "11d451c920c8dd2d126671fafc9f7e38a9105b58",
      "old_mode": 33188,
      "old_path": "fpdfsdk/pwl/cpwl_list_box.cpp",
      "new_id": "4cea17b6617cf2b977355acd485ba80714cfc822",
      "new_mode": 33188,
      "new_path": "fpdfsdk/pwl/cpwl_list_box.cpp"
    },
    {
      "type": "modify",
      "old_id": "6a58982aee6b70bcd4dd3c563a876b67dfcdaa3e",
      "old_mode": 33188,
      "old_path": "fpdfsdk/pwl/cpwl_list_box.h",
      "new_id": "cbfca4585f684758727010f284bbeb8c0abcebcb",
      "new_mode": 33188,
      "new_path": "fpdfsdk/pwl/cpwl_list_box.h"
    },
    {
      "type": "modify",
      "old_id": "ced049a17582afb899e0f3dc1c95c0cb13a558e2",
      "old_mode": 33188,
      "old_path": "fpdfsdk/pwl/cpwl_scroll_bar.cpp",
      "new_id": "4051d7be5164f90c87afa9d8a66b3aed4f6106d5",
      "new_mode": 33188,
      "new_path": "fpdfsdk/pwl/cpwl_scroll_bar.cpp"
    },
    {
      "type": "modify",
      "old_id": "3592423a7d02b2b9d310d4a310fa4652a7894fd2",
      "old_mode": 33188,
      "old_path": "fpdfsdk/pwl/cpwl_scroll_bar.h",
      "new_id": "40660db1f615fe29f0e315a79bdafdbb71cc0434",
      "new_mode": 33188,
      "new_path": "fpdfsdk/pwl/cpwl_scroll_bar.h"
    },
    {
      "type": "modify",
      "old_id": "061d024382c8e70215ed9a4a2493751f0e580816",
      "old_mode": 33188,
      "old_path": "fpdfsdk/pwl/cpwl_special_button.cpp",
      "new_id": "8e5f1b8d48a590207f83a2c1582ab2edde83e723",
      "new_mode": 33188,
      "new_path": "fpdfsdk/pwl/cpwl_special_button.cpp"
    },
    {
      "type": "modify",
      "old_id": "606be78f319bd94b613c94d5dffd3e61341d33a5",
      "old_mode": 33188,
      "old_path": "fpdfsdk/pwl/cpwl_special_button.h",
      "new_id": "28c2a6b14c85d975950765ded6e9a8f1f516e47e",
      "new_mode": 33188,
      "new_path": "fpdfsdk/pwl/cpwl_special_button.h"
    },
    {
      "type": "modify",
      "old_id": "1fc2bd81573f16ea249e181dddd37c4c60483d79",
      "old_mode": 33188,
      "old_path": "fpdfsdk/pwl/cpwl_wnd.cpp",
      "new_id": "67671640730d70f76416f763c8bef1f4424d1c01",
      "new_mode": 33188,
      "new_path": "fpdfsdk/pwl/cpwl_wnd.cpp"
    },
    {
      "type": "modify",
      "old_id": "93938db648d711c64991a885c1a35b2606e5aa13",
      "old_mode": 33188,
      "old_path": "fpdfsdk/pwl/cpwl_wnd.h",
      "new_id": "921693f1489360de5474e571b09eec071d187da3",
      "new_mode": 33188,
      "new_path": "fpdfsdk/pwl/cpwl_wnd.h"
    }
  ]
}