)]}'
{
  "commit": "70e66193fbc19cdc2eec1ad6eac7de13e1a003f5",
  "tree": "d6b559f1277618dec5e52078ec9c6465e478a459",
  "parents": [
    "2aabfc97f4654bd25f3886e42e40e4a96b43cae1"
  ],
  "author": {
    "name": "Lei Zhang",
    "email": "thestig@chromium.org",
    "time": "Fri Sep 18 20:50:51 2020 +0000"
  },
  "committer": {
    "name": "Chromium commit bot",
    "email": "commit-bot@chromium.org",
    "time": "Fri Sep 18 20:50:51 2020 +0000"
  },
  "message": "Make char widths signed again.\n\nUndo https://pdfium-review.googlesource.com/24410, because widths can be\nnegative for font glyphs. To fix https://crbug.com/806612, the correct\nsolution would have been to just delete the failing assertion. The CL\nbeing reverted did that already, but for different reasons. (As\ndiscussed on the code review, the assertion in question could not fail\nwhen widths are unsigned.)\n\nBug: chromium:806612,chromium:1128284\nChange-Id: Idca065ef9ade650613f8f39393d8513cedf31b6e\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/73770\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Hui Yingst \u003cnigi@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "f9b1e7a7c451c8210653d8ebcf8a1f1396665263",
      "old_mode": 33188,
      "old_path": "core/fpdfapi/font/cpdf_cidfont.cpp",
      "new_id": "200ee50973864dabb3ef1dec6dd4d3a1446ff591",
      "new_mode": 33188,
      "new_path": "core/fpdfapi/font/cpdf_cidfont.cpp"
    },
    {
      "type": "modify",
      "old_id": "7935999ecaf27289fa77baec46df949805eab12b",
      "old_mode": 33188,
      "old_path": "core/fpdfapi/font/cpdf_cidfont.h",
      "new_id": "5a51e4012a581459d1c9ab240bff983ec42456bc",
      "new_mode": 33188,
      "new_path": "core/fpdfapi/font/cpdf_cidfont.h"
    },
    {
      "type": "modify",
      "old_id": "8953350ff6f702bd4fce61af8c55a69159645e6e",
      "old_mode": 33188,
      "old_path": "core/fpdfapi/font/cpdf_font.cpp",
      "new_id": "80a3f4a5be9ae2ea38f55a6266bfff5540110a9b",
      "new_mode": 33188,
      "new_path": "core/fpdfapi/font/cpdf_font.cpp"
    },
    {
      "type": "modify",
      "old_id": "77d763cedd1b70dad6382e78f825d9d81959c202",
      "old_mode": 33188,
      "old_path": "core/fpdfapi/font/cpdf_font.h",
      "new_id": "0bf505350ac30c3a9218436d33eb7f57e7975fcc",
      "new_mode": 33188,
      "new_path": "core/fpdfapi/font/cpdf_font.h"
    },
    {
      "type": "modify",
      "old_id": "29f28611deca5f330d02b23c78234ea92becdad3",
      "old_mode": 33188,
      "old_path": "core/fpdfapi/font/cpdf_simplefont.cpp",
      "new_id": "b90accd8d7bc2ad4bb1629852745226339241c9e",
      "new_mode": 33188,
      "new_path": "core/fpdfapi/font/cpdf_simplefont.cpp"
    },
    {
      "type": "modify",
      "old_id": "11359c3f5fc0e2e9d620ff8c6f80a573d3a6572e",
      "old_mode": 33188,
      "old_path": "core/fpdfapi/font/cpdf_simplefont.h",
      "new_id": "0e7e9e03ea3b3885bb51dbf9edb53d78e8797b52",
      "new_mode": 33188,
      "new_path": "core/fpdfapi/font/cpdf_simplefont.h"
    },
    {
      "type": "modify",
      "old_id": "ca8345206fdb0bfc71c24fde14611a452fa185f5",
      "old_mode": 33188,
      "old_path": "core/fpdfapi/font/cpdf_type3char.h",
      "new_id": "70fa918d46a23b5f563c5cfdd5f820a45e7334f9",
      "new_mode": 33188,
      "new_path": "core/fpdfapi/font/cpdf_type3char.h"
    },
    {
      "type": "modify",
      "old_id": "124245d87403c08f45f3791c3bdd43cd4d6a65be",
      "old_mode": 33188,
      "old_path": "core/fpdfapi/font/cpdf_type3font.cpp",
      "new_id": "ac31e203bea8c156e9296956c6ecd715c005bdef",
      "new_mode": 33188,
      "new_path": "core/fpdfapi/font/cpdf_type3font.cpp"
    },
    {
      "type": "modify",
      "old_id": "8205aa766b2a0e09b281496ce34d77ee437abe77",
      "old_mode": 33188,
      "old_path": "core/fpdfapi/font/cpdf_type3font.h",
      "new_id": "0db2f9f8dea80d7fd07085511cf3c7a0f7a9a849",
      "new_mode": 33188,
      "new_path": "core/fpdfapi/font/cpdf_type3font.h"
    },
    {
      "type": "modify",
      "old_id": "b05b2103ca09bd948c31427614be4fa7cec2ea2f",
      "old_mode": 33188,
      "old_path": "core/fpdfapi/render/charposlist.cpp",
      "new_id": "5b09f29e8dc64c85a91a8a4397cdc7a3f2c503a1",
      "new_mode": 33188,
      "new_path": "core/fpdfapi/render/charposlist.cpp"
    },
    {
      "type": "modify",
      "old_id": "fc114d4970900752e9d299fd68c8b06405ab7c92",
      "old_mode": 33188,
      "old_path": "core/fpdfdoc/cpdf_variabletext.cpp",
      "new_id": "f96f4c22a10d8273abc6f40db9067af2da40abc3",
      "new_mode": 33188,
      "new_path": "core/fpdfdoc/cpdf_variabletext.cpp"
    },
    {
      "type": "modify",
      "old_id": "aa4701551fe2480dde0d4934d4f289d8212567e1",
      "old_mode": 33188,
      "old_path": "core/fpdfdoc/cpdf_variabletext.h",
      "new_id": "1d3fb59380353b697d44e799d2ee5311c6897cf2",
      "new_mode": 33188,
      "new_path": "core/fpdfdoc/cpdf_variabletext.h"
    },
    {
      "type": "modify",
      "old_id": "cc901fadbae065075850eccbc398a696c18b8995",
      "old_mode": 33188,
      "old_path": "core/fpdftext/cpdf_textpage.cpp",
      "new_id": "b355cc951238e42a52c7f99a7f513447b59346ba",
      "new_mode": 33188,
      "new_path": "core/fpdftext/cpdf_textpage.cpp"
    },
    {
      "type": "modify",
      "old_id": "b97a3b45bd60621b27b57bdee5d934ffd7263d64",
      "old_mode": 33188,
      "old_path": "core/fxge/apple/fx_apple_platform.cpp",
      "new_id": "309afb4acc853ba4074eefb73fda14d7a6141c65",
      "new_mode": 33188,
      "new_path": "core/fxge/apple/fx_apple_platform.cpp"
    },
    {
      "type": "modify",
      "old_id": "0c5849b8bd5438d2d5b5beac5a8484b234af4cf7",
      "old_mode": 33188,
      "old_path": "core/fxge/cfx_font.cpp",
      "new_id": "99dad648aa3a25fe9387a7559bb6a82eb3348d0e",
      "new_mode": 33188,
      "new_path": "core/fxge/cfx_font.cpp"
    },
    {
      "type": "modify",
      "old_id": "d421a1ad79c817f8e976ddfca1e4873f5705917b",
      "old_mode": 33188,
      "old_path": "core/fxge/cfx_font.h",
      "new_id": "31e5c7e01b73b023d92ee59145dbbbace3470b70",
      "new_mode": 33188,
      "new_path": "core/fxge/cfx_font.h"
    },
    {
      "type": "modify",
      "old_id": "f51beead4b364c1c31971e1d4a033c6f08448d2b",
      "old_mode": 33188,
      "old_path": "core/fxge/cfx_glyphcache.cpp",
      "new_id": "0c81edc0b51831e34f7e9e6df137e7967f86753f",
      "new_mode": 33188,
      "new_path": "core/fxge/cfx_glyphcache.cpp"
    },
    {
      "type": "modify",
      "old_id": "9e85fe971ef12c0af99ea2d7c4054b3e4055dcac",
      "old_mode": 33188,
      "old_path": "core/fxge/cfx_glyphcache.h",
      "new_id": "565cc6e7c71c11dd5f9946d250deec278d07b54f",
      "new_mode": 33188,
      "new_path": "core/fxge/cfx_glyphcache.h"
    },
    {
      "type": "modify",
      "old_id": "136bb6b2176b7b37f44705110085c5180ff12392",
      "old_mode": 33188,
      "old_path": "core/fxge/skia/fx_skia_device_embeddertest.cpp",
      "new_id": "66a3f60aa862c24a17d11ed3118d0f50c7382481",
      "new_mode": 33188,
      "new_path": "core/fxge/skia/fx_skia_device_embeddertest.cpp"
    },
    {
      "type": "modify",
      "old_id": "8d0c301dde5d048ed43d96732516a68ef233acf2",
      "old_mode": 33188,
      "old_path": "core/fxge/text_char_pos.h",
      "new_id": "ee4e670eda7c60f39dbcf10a4cb49f2cad0dce5d",
      "new_mode": 33188,
      "new_path": "core/fxge/text_char_pos.h"
    },
    {
      "type": "modify",
      "old_id": "ed3aae62c7e9a1287978f5db2f5b65b193a3d96d",
      "old_mode": 33188,
      "old_path": "fpdfsdk/fpdf_edit_embeddertest.cpp",
      "new_id": "c673766ee7f635c5f064d2603f7f251b1f2fcd23",
      "new_mode": 33188,
      "new_path": "fpdfsdk/fpdf_edit_embeddertest.cpp"
    },
    {
      "type": "modify",
      "old_id": "fc9780a409442938df1f1304aa90af8f4eda82b2",
      "old_mode": 33188,
      "old_path": "fpdfsdk/fpdf_edittext.cpp",
      "new_id": "b3815f8adccca22e521f25688f1751885709277c",
      "new_mode": 33188,
      "new_path": "fpdfsdk/fpdf_edittext.cpp"
    },
    {
      "type": "modify",
      "old_id": "9d14e493fbac0cbce8d9816cfe2fdb22ea56162d",
      "old_mode": 33188,
      "old_path": "fpdfsdk/pwl/cpwl_edit_impl.cpp",
      "new_id": "8db0cdf0d735129fa6e4ae4c31547b27d674ba54",
      "new_mode": 33188,
      "new_path": "fpdfsdk/pwl/cpwl_edit_impl.cpp"
    },
    {
      "type": "modify",
      "old_id": "f16be7e406db8b8912004e8cbf7237b935c36662",
      "old_mode": 33188,
      "old_path": "fpdfsdk/pwl/cpwl_edit_impl.h",
      "new_id": "9bba4f07e5685ef0926f0a104f4fce4a9da11f59",
      "new_mode": 33188,
      "new_path": "fpdfsdk/pwl/cpwl_edit_impl.h"
    },
    {
      "type": "modify",
      "old_id": "1e2b2a5aa7cd8bf6476d27907a8f59b844ba5e9c",
      "old_mode": 33188,
      "old_path": "fxbarcode/oned/BC_OneDimWriter.cpp",
      "new_id": "b4db093e755e7c8184fd87ba8cb304683c4bd941",
      "new_mode": 33188,
      "new_path": "fxbarcode/oned/BC_OneDimWriter.cpp"
    },
    {
      "type": "modify",
      "old_id": "54057299408696b37d2681ea072f50922b87a522",
      "old_mode": 33188,
      "old_path": "testing/resources/pixel/bug_1128284_expected.pdf.0.png",
      "new_id": "6a0df398b2e53e90f01421951bfb2ddc4fb3ba56",
      "new_mode": 33188,
      "new_path": "testing/resources/pixel/bug_1128284_expected.pdf.0.png"
    },
    {
      "type": "modify",
      "old_id": "5b290b9cfa3cd0cb0c4cf51cf31874be8e663a9f",
      "old_mode": 33188,
      "old_path": "xfa/fgas/layout/cfx_rtfbreak.cpp",
      "new_id": "3523c630cb068ce423d1a4d9364bae46dbc07422",
      "new_mode": 33188,
      "new_path": "xfa/fgas/layout/cfx_rtfbreak.cpp"
    },
    {
      "type": "modify",
      "old_id": "139e0a34874a0430228978f47904b57b66a643c7",
      "old_mode": 33188,
      "old_path": "xfa/fgas/layout/cfx_txtbreak.cpp",
      "new_id": "496b85137055ea3a343839a1beaedf5e822036b8",
      "new_mode": 33188,
      "new_path": "xfa/fgas/layout/cfx_txtbreak.cpp"
    }
  ]
}