commit 70e8a41b9a4a7234dabb9e76eebc931e05f96951
author Lei Zhang <thestig@chromium.org> Fri Sep 19 14:05:00 2025 -0700
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Sep 19 14:05:00 2025 -0700
tree a14285bfbc9bde6e4d6b8ab21153c81d3e922de4
parent ffd6e6bff89358331ae919561fb633e0c321d9c9

Rename a member variable in CPDF_TextPage

Since the variable is named "mFoo" instead of "m_Foo", it avoided
detection when "m_Foo" member variables got mass renamed to "foo_".

Change-Id: I3e06c4a14fe66004e3596d24f4d39b8bf0cde0c0
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/135910
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

core/fpdftext/cpdf_textpage.cpp

diff --git a/core/fpdftext/cpdf_textpage.cpp b/core/fpdftext/cpdf_textpage.cpp
index 49e75ca..b9ec5f1 100644
--- a/core/fpdftext/cpdf_textpage.cpp
+++ b/core/fpdftext/cpdf_textpage.cpp
@@ -759,11 +759,11 @@
       ProcessFormObject(pObj->AsForm(), CFX_Matrix());
     }
   }
-  for (const auto& obj : mTextObjects) {
+  for (const auto& obj : text_objects_) {
     ProcessTextObject(obj);
   }
 
-  mTextObjects.clear();
+  text_objects_.clear();
   CloseTempLine();
 }
 
@@ -889,19 +889,19 @@
     return;
   }
 
-  size_t count = mTextObjects.size();
+  size_t count = text_objects_.size();
   TransformedTextObject new_obj;
   new_obj.text_obj_ = pTextObj;
   new_obj.form_matrix_ = form_matrix;
   if (count == 0) {
-    mTextObjects.push_back(new_obj);
+    text_objects_.push_back(new_obj);
     return;
   }
   if (IsSameAsPreTextObject(pTextObj, pObjList, ObjPos)) {
     return;
   }
 
-  TransformedTextObject prev_obj = mTextObjects[count - 1];
+  TransformedTextObject prev_obj = text_objects_[count - 1];
   size_t nItem = prev_obj.text_obj_->CountItems();
   if (nItem == 0) {
     return;
@@ -930,24 +930,24 @@
       display_matrix_.Transform(form_matrix.Transform(pTextObj->GetPos()));
   if (fabs(this_pos.y - prev_pos.y) > threshold * 2) {
     for (size_t i = 0; i < count; ++i) {
-      ProcessTextObject(mTextObjects[i]);
+      ProcessTextObject(text_objects_[i]);
     }
-    mTextObjects.clear();
-    mTextObjects.push_back(new_obj);
+    text_objects_.clear();
+    text_objects_.push_back(new_obj);
     return;
   }
 
   for (size_t i = count; i > 0; --i) {
-    TransformedTextObject prev_text_obj = mTextObjects[i - 1];
+    TransformedTextObject prev_text_obj = text_objects_[i - 1];
     CFX_PointF new_prev_pos =
         display_matrix_.Transform(prev_text_obj.form_matrix_.Transform(
             prev_text_obj.text_obj_->GetPos()));
     if (this_pos.x >= new_prev_pos.x) {
-      mTextObjects.insert(mTextObjects.begin() + i, new_obj);
+      text_objects_.insert(text_objects_.begin() + i, new_obj);
       return;
     }
   }
-  mTextObjects.insert(mTextObjects.begin(), new_obj);
+  text_objects_.insert(text_objects_.begin(), new_obj);
 }
 
 CPDF_TextPage::MarkedContentState CPDF_TextPage::PreMarkedContent(

core/fpdftext/cpdf_textpage.h

diff --git a/core/fpdftext/cpdf_textpage.h b/core/fpdftext/cpdf_textpage.h
index 4ebd80e..2a5aa01 100644
--- a/core/fpdftext/cpdf_textpage.h
+++ b/core/fpdftext/cpdf_textpage.h
@@ -192,7 +192,7 @@
   const bool rtl_;
   const CFX_Matrix display_matrix_;
   std::vector<CFX_FloatRect> sel_rects_;
-  std::vector<TransformedTextObject> mTextObjects;
+  std::vector<TransformedTextObject> text_objects_;
   TextOrientation textline_dir_ = TextOrientation::kUnknown;
   CFX_FloatRect curline_rect_;
 };