commit 87770748ee398aac641b3719746d5de8e055d078
author Tom Sepez <tsepez@chromium.org> Tue Jan 07 22:34:38 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Tue Jan 07 22:34:38 2020 +0000
tree 44ffa2c9ba5d8ce803e377704fa37f9871543944
parent 92f922266ad9aa0dbc0fcc183200d07f93cecaec

Re-enable CXFALayoutItemEmbedderTest.Bug_306123

The leak which kept this test disabled no longer reproduces,
likely as a result of the work to manage layout items as retainable
tree-shared objects. The referenced bug is tracking both a leak and
a functional issue, with the functional issue still remaining.

Bug: chromium:306123
Change-Id: I6f529c5d36010c0f0593b3e7dc8a0c932a5c4d1d
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/64533
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

xfa/fxfa/layout/cxfa_layoutitem_embeddertest.cpp

diff --git a/xfa/fxfa/layout/cxfa_layoutitem_embeddertest.cpp b/xfa/fxfa/layout/cxfa_layoutitem_embeddertest.cpp
index 8a31402..035da87 100644
--- a/xfa/fxfa/layout/cxfa_layoutitem_embeddertest.cpp
+++ b/xfa/fxfa/layout/cxfa_layoutitem_embeddertest.cpp
@@ -15,13 +15,9 @@
 // Leaks. See https://crbug.com/pdfium/1301
 #define MAYBE_Bug_1301 DISABLED_Bug_1301
 
-// Leaks. See https:://crbug.com/306123
-#define MAYBE_Bug_306123 DISABLED_Bug_306123
-
 #else
 #define MAYBE_Bug_1265 Bug_1265
 #define MAYBE_Bug_1301 Bug_1301
-#define MAYBE_Bug_306123 Bug_306123
 #endif
 
 TEST_F(CXFALayoutItemEmbedderTest, MAYBE_Bug_1265) {
@@ -45,7 +41,7 @@
   UnloadPage(page1);
 }
 
-TEST_F(CXFALayoutItemEmbedderTest, MAYBE_Bug_306123) {
+TEST_F(CXFALayoutItemEmbedderTest, Bug_306123) {
   EXPECT_TRUE(OpenDocument("bug_306123.pdf"));
   FPDF_PAGE page0 = LoadPage(0);
   FPDF_PAGE page1 = LoadPage(1);