commit 87b9e3abc6a78bec8e9485fe1d61940d9e73888c
author Tom Sepez <tsepez@chromium.org> Wed Nov 20 23:45:43 2019 +0000
committer Chromium commit bot <commit-bot@chromium.org> Wed Nov 20 23:45:43 2019 +0000
tree 44069ae9482442974f300e253f6e4211e869908e
parent f5531fcb888ca6934a891354f6a1da7959f33400

Pass span<> arguments in GetPostScriptFromEmf().

Preferable to a const-ref vector of a specific allocator type.

Change-Id: I691b3da6716ed99d3b00e5e11d65e7e9e4d0c30a
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/62633
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

testing/embedder_test.cpp

diff --git a/testing/embedder_test.cpp b/testing/embedder_test.cpp
index b092bc6..4507bb9 100644
--- a/testing/embedder_test.cpp
+++ b/testing/embedder_test.cpp
@@ -420,7 +420,7 @@
 
 // static
 std::string EmbedderTest::GetPostScriptFromEmf(
-    const std::vector<uint8_t>& emf_data) {
+    pdfium::span<const uint8_t> emf_data) {
   // This comes from Emf::InitFromData() in Chromium.
   HENHMETAFILE emf = SetEnhMetaFileBits(emf_data.size(), emf_data.data());
   if (!emf)

testing/embedder_test.h

diff --git a/testing/embedder_test.h b/testing/embedder_test.h
index a088577..0b9abbe 100644
--- a/testing/embedder_test.h
+++ b/testing/embedder_test.h
@@ -21,6 +21,7 @@
 #include "testing/fake_file_access.h"
 #include "testing/free_deleter.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/base/span.h"
 
 class TestLoader;
 
@@ -168,8 +169,8 @@
                                                        int flags);
 
   // Get the PostScript data from |emf_data|.
-  static std::string GetPostScriptFromEmf(const std::vector<uint8_t>& emf_data);
-#endif
+  static std::string GetPostScriptFromEmf(pdfium::span<const uint8_t> emf_data);
+#endif  // defined(OS_WIN)
 
  protected:
   using PageNumberToHandleMap = std::map<int, FPDF_PAGE>;