commit 89a94c1b9901550cc8cebe47c4df5acb30a14286
author Lei Zhang <thestig@chromium.org> Tue Jan 21 17:52:21 2025 -0800
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jan 21 17:52:21 2025 -0800
tree 8c7e00bb556536e69b62e24d0c52937c514f5c9b
parent 603caea4e21116f65e76e8c08c23a89f65e0c73d

Fix test helper to get correct indices from rotated_text.pdf

Fix GetRotatedTextFirstCharIndexForQuadrant() so it actually returns the
correct indices for the first character in each quadrant.

Add some more FPDFText_GetUnicode() calls to a few other test cases to
make sure they are using the expected indices.

Change-Id: I3c98cc853b63eb36075e689c63d617cc940a2740
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/127993
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Thomas Sepez <tsepez@google.com>

fpdfsdk/fpdf_text_embeddertest.cpp

diff --git a/fpdfsdk/fpdf_text_embeddertest.cpp b/fpdfsdk/fpdf_text_embeddertest.cpp
index f2528d6..e61f1e7 100644
--- a/fpdfsdk/fpdf_text_embeddertest.cpp
+++ b/fpdfsdk/fpdf_text_embeddertest.cpp
@@ -4,6 +4,7 @@
 
 #include <algorithm>
 #include <array>
+#include <string>
 #include <utility>
 #include <vector>
 
@@ -31,8 +32,12 @@
 
 // For use with rotated_text.pdf.
 int GetRotatedTextFirstCharIndexForQuadrant(int quadrant) {
-  static constexpr int kSubstringsSize[] = {
-      std::size("Hello,"), std::size(" world!\r\n"), std::size("Goodbye,")};
+  // Unlike hello_world.pdf, rotated_text.pdf has an extra space before
+  // "Goodbye".
+  static constexpr size_t kSubstringsSize[] = {
+      std::char_traits<char>::length("Hello, "),
+      std::char_traits<char>::length("world!\r\n "),
+      std::char_traits<char>::length("Goodbye, ")};
   switch (quadrant) {
     case 0:
       return 0;
@@ -261,6 +266,8 @@
   ASSERT_TRUE(textpage);
 
   EXPECT_EQ(12.0, FPDFText_GetFontSize(textpage.get(), 0));
+  EXPECT_EQ(static_cast<uint32_t>('e'), FPDFText_GetUnicode(textpage.get(), 1));
+  EXPECT_EQ(static_cast<uint32_t>('l'), FPDFText_GetUnicode(textpage.get(), 2));
 
   double x = 0.0;
   double y = 0.0;
@@ -1509,10 +1516,10 @@
   EXPECT_EQ(static_cast<uint32_t>('w'),
             FPDFText_GetUnicode(text_page.get(),
                                 GetRotatedTextFirstCharIndexForQuadrant(1)));
-  EXPECT_EQ(static_cast<uint32_t>('o'),
+  EXPECT_EQ(static_cast<uint32_t>('G'),
             FPDFText_GetUnicode(text_page.get(),
                                 GetRotatedTextFirstCharIndexForQuadrant(2)));
-  EXPECT_EQ(static_cast<uint32_t>('o'),
+  EXPECT_EQ(static_cast<uint32_t>('w'),
             FPDFText_GetUnicode(text_page.get(),
                                 GetRotatedTextFirstCharIndexForQuadrant(3)));
 
@@ -1716,6 +1723,14 @@
   ScopedFPDFTextPage text_page(FPDFText_LoadPage(page.get()));
   ASSERT_TRUE(text_page);
 
+  // Make sure the tests below are testing the letter 'A'.
+  EXPECT_EQ(static_cast<uint32_t>('A'),
+            FPDFText_GetUnicode(text_page.get(), 0));
+  EXPECT_EQ(static_cast<uint32_t>('A'),
+            FPDFText_GetUnicode(text_page.get(), 4));
+  EXPECT_EQ(static_cast<uint32_t>('A'),
+            FPDFText_GetUnicode(text_page.get(), 8));
+
   // Check the character box size.
   double left;
   double right;