Convert FPDFRenderLoadImageEmbedderTests to pixel tests.
Pixel tests are easier to visualize, do not require code, and run in
parallel.
Change-Id: I4bd7ab1b895ad7220ddea7854256b3b9bc2ee611
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/52750
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
diff --git a/core/fpdfapi/render/BUILD.gn b/core/fpdfapi/render/BUILD.gn
index 85d5c01..b840c9e 100644
--- a/core/fpdfapi/render/BUILD.gn
+++ b/core/fpdfapi/render/BUILD.gn
@@ -77,7 +77,6 @@
pdfium_embeddertest_source_set("embeddertests") {
sources = [
- "fpdf_render_loadimage_embeddertest.cpp",
"fpdf_render_pattern_embeddertest.cpp",
]
pdfium_root_dir = "../../../"
diff --git a/core/fpdfapi/render/fpdf_render_loadimage_embeddertest.cpp b/core/fpdfapi/render/fpdf_render_loadimage_embeddertest.cpp
deleted file mode 100644
index 30ba2d6..0000000
--- a/core/fpdfapi/render/fpdf_render_loadimage_embeddertest.cpp
+++ /dev/null
@@ -1,51 +0,0 @@
-// Copyright 2015 PDFium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include <memory>
-
-#include "public/cpp/fpdf_scopers.h"
-#include "testing/embedder_test.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-class FPDFRenderLoadImageEmbedderTest : public EmbedderTest {};
-
-TEST_F(FPDFRenderLoadImageEmbedderTest, Bug_554151) {
- // Test scanline downsampling with a BitsPerComponent of 4.
- // Should not crash.
- EXPECT_TRUE(OpenDocument("bug_554151.pdf"));
- FPDF_PAGE page = LoadPage(0);
- ASSERT_TRUE(page);
- ScopedFPDFBitmap bitmap = RenderLoadedPage(page);
- CompareBitmap(bitmap.get(), 612, 792, "1940568c9ba33bac5d0b1ee9558c76b3");
- UnloadPage(page);
-}
-
-TEST_F(FPDFRenderLoadImageEmbedderTest, Bug_557223) {
- // Should not crash
- EXPECT_TRUE(OpenDocument("bug_557223.pdf"));
- FPDF_PAGE page = LoadPage(0);
- ASSERT_TRUE(page);
- ScopedFPDFBitmap bitmap = RenderLoadedPage(page);
- CompareBitmap(bitmap.get(), 24, 24, "dc0ea1b743c2edb22c597cadc8537f7b");
- UnloadPage(page);
-}
-
-TEST_F(FPDFRenderLoadImageEmbedderTest, Bug_603518) {
- // Should not crash
- EXPECT_TRUE(OpenDocument("bug_603518.pdf"));
- FPDF_PAGE page = LoadPage(0);
- EXPECT_NE(nullptr, page);
- ScopedFPDFBitmap bitmap = RenderLoadedPage(page);
- CompareBitmap(bitmap.get(), 749, 749, "b9e75190cdc5edf0069a408744ca07dc");
- UnloadPage(page);
-}
-
-TEST_F(FPDFRenderLoadImageEmbedderTest, Bug_1087) {
- EXPECT_TRUE(OpenDocument("bug_1087.pdf"));
- FPDF_PAGE page = LoadPage(0);
- ASSERT_TRUE(page);
- ScopedFPDFBitmap bitmap = RenderLoadedPage(page);
- CompareBitmap(bitmap.get(), 548, 238, "2aac40afa121feb0f38883cb04a55001");
- UnloadPage(page);
-}
diff --git a/testing/resources/bug_554151.pdf b/testing/resources/bug_554151.pdf
deleted file mode 100644
index fa770a7..0000000
--- a/testing/resources/bug_554151.pdf
+++ /dev/null
@@ -1,70 +0,0 @@
-%PDF-1.7
-% ò¤ô
-
-1 0 obj
-<<
- /Pages 2 0 R
->>
-endobj
-
-2 0 obj
-<<
- /Kids [ 3 0 R ]
->>
-endobj
-
-3 0 obj
-<<
- /Contents 6 0 R
- /Resources 5 0 R
->>
-endobj
-
-6 0 obj
-<<>>
-stream
-612 0.0 0.0 104000 0 0 cm
-/XBad Do
-endstream
-endobj
-
-5 0 obj
-<<
- /XObject <<
- /XBad 7 0 R
- >>
->>
-endobj
-
-7 0 obj
-<<
- /Type /XObject
- /Subtype /Image
- /Width 612
- /Height 104000
- /ColorSpace /DeviceRGB
- /BitsPerComponent 4
- /Length 0
- /Decode [1.0]
->>
-stream
-FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF
-endobj
-
-xref
-0 8
-0000000000 65535 f
-0000000016 00000 n
-0000000053 00000 n
-0000000093 00000 n
-0000000000 65535 f
-0000000225 00000 n
-0000000152 00000 n
-0000000282 00000 n
-trailer <<
- /Root 1 0 R
- /Size 8
->>
-startxref
-1370
-%%EOF
diff --git a/testing/resources/bug_557223.pdf b/testing/resources/bug_557223.pdf
deleted file mode 100644
index e80805a..0000000
--- a/testing/resources/bug_557223.pdf
+++ /dev/null
Binary files differ
diff --git a/testing/resources/bug_1087.pdf b/testing/resources/pixel/bug_1087.pdf
similarity index 100%
rename from testing/resources/bug_1087.pdf
rename to testing/resources/pixel/bug_1087.pdf
Binary files differ
diff --git a/testing/resources/pixel/bug_1087_expected.pdf.0.png b/testing/resources/pixel/bug_1087_expected.pdf.0.png
new file mode 100644
index 0000000..f1a283f
--- /dev/null
+++ b/testing/resources/pixel/bug_1087_expected.pdf.0.png
Binary files differ
diff --git a/testing/resources/bug_554151.in b/testing/resources/pixel/bug_554151.in
similarity index 100%
rename from testing/resources/bug_554151.in
rename to testing/resources/pixel/bug_554151.in
diff --git a/testing/resources/pixel/bug_554151_expected.pdf.0.png b/testing/resources/pixel/bug_554151_expected.pdf.0.png
new file mode 100644
index 0000000..08c11b0
--- /dev/null
+++ b/testing/resources/pixel/bug_554151_expected.pdf.0.png
Binary files differ
diff --git a/testing/resources/bug_557223.in b/testing/resources/pixel/bug_557223.in
similarity index 100%
rename from testing/resources/bug_557223.in
rename to testing/resources/pixel/bug_557223.in
Binary files differ
diff --git a/testing/resources/pixel/bug_557223_expected.pdf.0.png b/testing/resources/pixel/bug_557223_expected.pdf.0.png
new file mode 100644
index 0000000..5ac2c59
--- /dev/null
+++ b/testing/resources/pixel/bug_557223_expected.pdf.0.png
Binary files differ
diff --git a/testing/resources/bug_603518.pdf b/testing/resources/pixel/bug_603518.pdf
similarity index 100%
rename from testing/resources/bug_603518.pdf
rename to testing/resources/pixel/bug_603518.pdf
Binary files differ
diff --git a/testing/resources/pixel/bug_603518_expected.pdf.0.png b/testing/resources/pixel/bug_603518_expected.pdf.0.png
new file mode 100644
index 0000000..6d599ab
--- /dev/null
+++ b/testing/resources/pixel/bug_603518_expected.pdf.0.png
Binary files differ
