commit 947d9082fc7904aa755878419149afeea3523d3e
author Tom Sepez <tsepez@chromium.org> Tue Jan 07 23:45:29 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Tue Jan 07 23:45:29 2020 +0000
tree 79e2ba877c4dcb7c9dc4c1782864f21618725bae
parent ae5d92af623ac0949f076e6a916dbc1fb0f13e1d

Remove duplicate SetLayoutItem(nullptr) in CXFA_ContentLayoutItem

The same thing happens immediately after in the CXFA_LayoutItem
superclass dtor. Found while trying to diagnose another bug, this
gives one less place to worry about.

Change-Id: Ib1f6a0cf2ad57e7518045e7488962cc1ad603fb7
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/64550
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

xfa/fxfa/layout/cxfa_contentlayoutitem.cpp

diff --git a/xfa/fxfa/layout/cxfa_contentlayoutitem.cpp b/xfa/fxfa/layout/cxfa_contentlayoutitem.cpp
index 157c7a3..2e9bd23 100644
--- a/xfa/fxfa/layout/cxfa_contentlayoutitem.cpp
+++ b/xfa/fxfa/layout/cxfa_contentlayoutitem.cpp
@@ -23,9 +23,6 @@
 
 CXFA_ContentLayoutItem::~CXFA_ContentLayoutItem() {
   RemoveSelf();
-  CJX_Object* pJsObject = GetFormNode()->JSObject();
-  if (pJsObject->GetLayoutItem() == this)
-    pJsObject->SetLayoutItem(nullptr);
 }
 
 CXFA_ContentLayoutItem* CXFA_ContentLayoutItem::GetFirst() {