tree 8ffa388c6df55ef166005020f7d3cec86383ee7e
parent 3189488fe27463d7e827568621d9d81135b6358d
author Lei Zhang <thestig@chromium.org> 1709248765 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1709248765 +0000

Remove out-parameters from CPDF_ColorState::Set{Color,Pattern}()

For these 2 methods, remove the FX_COLORREF* out-parameter and return
the value instead. This reveals a code path in SetColor() that never
wrote to the out-parameter. Preserve this behavior by returning an
optional FX_COLORREF. Also:

- Make a note of the 0xFFFFFFFF sentinel value where FX_COLORREF is
  defined.
- Change in-out parameters to use references instead of pointers.
- Remove DCHECKs that the parameters as not nullptr.
- Rename some variables to get rid of Hungarian notation.

Change-Id: I01be3d70be919b608d6146cd45b527b755c4dce9
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/117091
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Thomas Sepez <tsepez@google.com>