)]}'
{
  "commit": "9aeffb1954a18e4725994b10deb2aee98d521bd6",
  "tree": "ac19af0a27cfe483a35f726c5665319b3f6b81ec",
  "parents": [
    "460f5dc134b34bce8d1aea2050a619ef4f040725"
  ],
  "author": {
    "name": "Hui Yingst",
    "email": "nigi@chromium.org",
    "time": "Thu Apr 16 21:38:30 2020 +0000"
  },
  "committer": {
    "name": "Chromium commit bot",
    "email": "commit-bot@chromium.org",
    "time": "Thu Apr 16 21:38:30 2020 +0000"
  },
  "message": "Fix embedder test FPDFFormFillEmbedderTest.BUG_1281 for Skia.\n\nWhen drawing the second bitmap with FPDF_REVERSE_BYTE_ORDER,\nSkia/SkiaPaths renders a blue rectangle instead of a red one. This is\nbecause |bRgbByteOrder| is ignored when setting color type for bitmap\ninside CFX_SkiaDeviceDriver, while it\u0027s supposed to enforce the reverse\nbyte order of color.\n\nFor color rendering, Skia and SkiaPaths are always using color type\n|kN32_SkColorType|, of which the value changes between\n|kRGBA_8888_SkColorType| and |kBGRA_8888_SkColorType| depending on\nwhether the program is running on a big endian processor or not.\n\nTo make the byte order of color changeable instead of depending on the\nprocessor, this CL makes Skia and SkiaPaths both respect the value of\n|bRgbByteOrder| that\u0027s passed into CFX_SkiaDeviceDriver, and use\n|m_bRgbByteOrder| to hold its value and keep the color type consistent\nthroughout the rendering process just like AGG.\n\nIn addition to the fix, this CL also adds the expected hash values for\nSkia/SkiaPaths rendering results in the embedder test, since the small\ndiscrepancies for rendering small rectangles are expected with\nSkia/SkiaPaths enabled.\n\nBug: pdfium:1500\nChange-Id: Iad0762a04cc3f266accb4d48177ccb8fd95af894\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/68831\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Hui Yingst \u003cnigi@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "9e2e4230ad36b370f1bdbaa6bd2878482c08584a",
      "old_mode": 33188,
      "old_path": "core/fxge/skia/fx_skia_device.cpp",
      "new_id": "9f0414a7a6cdebc490fd657948187d617cb7b025",
      "new_mode": 33188,
      "new_path": "core/fxge/skia/fx_skia_device.cpp"
    },
    {
      "type": "modify",
      "old_id": "25717699e2f804556b1826236442c71cce5c7512",
      "old_mode": 33188,
      "old_path": "core/fxge/skia/fx_skia_device.h",
      "new_id": "d423f6f046552aa8b68a45adb5de1be5cdcc7e9b",
      "new_mode": 33188,
      "new_path": "core/fxge/skia/fx_skia_device.h"
    },
    {
      "type": "modify",
      "old_id": "436a44ce5464b643f7373b6929c01039bcbffd98",
      "old_mode": 33188,
      "old_path": "fpdfsdk/fpdf_formfill_embeddertest.cpp",
      "new_id": "dfee33c90e60b3d91fbbf616b47dff020b556682",
      "new_mode": 33188,
      "new_path": "fpdfsdk/fpdf_formfill_embeddertest.cpp"
    }
  ]
}