)]}'
{
  "commit": "c43b78543f78ca4c2985d610f5c53598be04e989",
  "tree": "bffc02a24f09f311971f56dbbf8f6e894498b5ae",
  "parents": [
    "d9dbe513fcc0ad396b864bce7f982cb0024d667e"
  ],
  "author": {
    "name": "Lei Zhang",
    "email": "thestig@chromium.org",
    "time": "Wed Sep 07 16:31:33 2022 +0000"
  },
  "committer": {
    "name": "Pdfium LUCI CQ",
    "email": "pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Wed Sep 07 16:31:33 2022 +0000"
  },
  "message": "Return const pointer from CPDF_Stream::GetInMemoryRawData().\n\nCallers to CPDF_Stream::GetInMemoryRawData() do not need the non-const\npointer to the data. GetInMemoryRawData() was only returning a non-const\npointer because fxcrt::MaybeOwned required it for the owned-data case.\n\nIn CPDF_StreamAcc, replace its MaybeOwned usage with absl::variant. Then\nthe variant can store either a read-only span, or some kind of owned\nmemory. Then CPDF_StreamAcc no longer need to have separate data and\nsize members.\n\nAs part of this CL, also restrict when GetInMemoryRawData() can be\ncalled, and update CPDF_StreamAcc to match that behavior. Update the\ncomments for GetInMemoryRawData() to better explain how it is intended\nto be used.\n\nChange-Id: I6a05e8b5314434447e45c44596c81771765756fb\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/97535\nReviewed-by: Tom Sepez \u003ctsepez@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "4bcd451c9fa926d71557fba34183091f1f257121",
      "old_mode": 33188,
      "old_path": "core/fpdfapi/parser/cpdf_stream.cpp",
      "new_id": "57ec20ced010e0b3c8103c95ffda061e2fa9b416",
      "new_mode": 33188,
      "new_path": "core/fpdfapi/parser/cpdf_stream.cpp"
    },
    {
      "type": "modify",
      "old_id": "b6e4966892ad51eb96da0d46d6721e992be871d2",
      "old_mode": 33188,
      "old_path": "core/fpdfapi/parser/cpdf_stream.h",
      "new_id": "5da2398f8b13eeda19cb14a1bb04984a3943fbaa",
      "new_mode": 33188,
      "new_path": "core/fpdfapi/parser/cpdf_stream.h"
    },
    {
      "type": "modify",
      "old_id": "485de023dbc34da7356ce78071f13484e1e0b035",
      "old_mode": 33188,
      "old_path": "core/fpdfapi/parser/cpdf_stream_acc.cpp",
      "new_id": "27de211bae3ee5432233f67cbd29598650d326aa",
      "new_mode": 33188,
      "new_path": "core/fpdfapi/parser/cpdf_stream_acc.cpp"
    },
    {
      "type": "modify",
      "old_id": "c6b71f14ab79f242c7ae74872018c67d74dbaebb",
      "old_mode": 33188,
      "old_path": "core/fpdfapi/parser/cpdf_stream_acc.h",
      "new_id": "3314a0ec82a0a959ab1be5f16b24cab728e2ce21",
      "new_mode": 33188,
      "new_path": "core/fpdfapi/parser/cpdf_stream_acc.h"
    }
  ]
}
