commit ca782b9c47bb6aaf1e612f008e2c66ea4045b071
author Tom Sepez <tsepez@chromium.org> Fri Sep 03 21:59:53 2021 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Sep 03 21:59:53 2021 +0000
tree 99e3e885d2002d0e294ebe7ac123df222134c72a
parent 55a5cdc1dccf8a801a9040dadec124c9b84453c4

Remove CPDF_ScaledRenderBuffer::m_pObject and m_pContext

Each is only referenced within a single method, set at the beginning,
and not used persistently elsewhere.

-- pack pointers closer together.

Change-Id: Ie714672f98ad3f28c2d4debea5860c6c3b4af277
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/84772
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

core/fpdfapi/render/cpdf_scaledrenderbuffer.cpp

diff --git a/core/fpdfapi/render/cpdf_scaledrenderbuffer.cpp b/core/fpdfapi/render/cpdf_scaledrenderbuffer.cpp
index 567e2d3..37f5c43 100644
--- a/core/fpdfapi/render/cpdf_scaledrenderbuffer.cpp
+++ b/core/fpdfapi/render/cpdf_scaledrenderbuffer.cpp
@@ -31,9 +31,7 @@
   if (m_pDevice->GetDeviceCaps(FXDC_RENDER_CAPS) & FXRC_GET_BITS)
     return true;
 
-  m_pContext = pContext;
   m_Rect = rect;
-  m_pObject = pObj;
   m_Matrix = CPDF_DeviceBuffer::CalculateMatrix(pDevice, rect, max_dpi,
                                                 /*scale=*/true);
   m_pBitmapDevice = std::make_unique<CFX_DefaultRenderDevice>();
@@ -58,8 +56,8 @@
     }
     m_Matrix.Scale(0.5f, 0.5f);
   }
-  m_pContext->GetBackground(m_pBitmapDevice->GetBitmap(), m_pObject.Get(),
-                            pOptions, m_Matrix);
+  pContext->GetBackground(m_pBitmapDevice->GetBitmap(), pObj, pOptions,
+                          m_Matrix);
   return true;
 }
 

core/fpdfapi/render/cpdf_scaledrenderbuffer.h

diff --git a/core/fpdfapi/render/cpdf_scaledrenderbuffer.h b/core/fpdfapi/render/cpdf_scaledrenderbuffer.h
index 0e7ac07..4c1b510 100644
--- a/core/fpdfapi/render/cpdf_scaledrenderbuffer.h
+++ b/core/fpdfapi/render/cpdf_scaledrenderbuffer.h
@@ -36,10 +36,8 @@
 
  private:
   UnownedPtr<CFX_RenderDevice> m_pDevice;
-  UnownedPtr<CPDF_RenderContext> m_pContext;
-  FX_RECT m_Rect;
-  UnownedPtr<const CPDF_PageObject> m_pObject;
   std::unique_ptr<CFX_DefaultRenderDevice> m_pBitmapDevice;
+  FX_RECT m_Rect;
   CFX_Matrix m_Matrix;
 };