Remove spurious calls to FPDF_GetDocPermissions()
There exist a few FPDF_GetDocPermissions() calls that do not check the
return result. Likely these existed in early PDFium builds to add test
coverage. That is no longer necessary, as there are test cases
specifically for FPDF_GetDocPermissions() in the modern code base.
Change-Id: Ia7949b46b9877139d6db454032ba62a0f67b186f
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/111230
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nigi <nigi@chromium.org>
diff --git a/samples/pdfium_test.cc b/samples/pdfium_test.cc
index 282c539..ec614e0 100644
--- a/samples/pdfium_test.cc
+++ b/samples/pdfium_test.cc
@@ -1590,8 +1590,6 @@
if (!FPDF_DocumentHasValidCrossReferenceTable(doc.get()))
fprintf(stderr, "Document has invalid cross reference table\n");
- (void)FPDF_GetDocPermissions(doc.get());
-
if (options().show_metadata) {
DumpMetaData(doc.get());
}
diff --git a/testing/embedder_test.cpp b/testing/embedder_test.cpp
index 4d31c91..c9919d3 100644
--- a/testing/embedder_test.cpp
+++ b/testing/embedder_test.cpp
@@ -415,7 +415,6 @@
if (doc_type == FORMTYPE_XFA_FULL || doc_type == FORMTYPE_XFA_FOREGROUND)
FPDF_LoadXFA(document_ptr);
- (void)FPDF_GetDocPermissions(document_ptr);
return true;
}
diff --git a/testing/fuzzers/pdfium_fuzzer_helper.cc b/testing/fuzzers/pdfium_fuzzer_helper.cc
index 1d26787..5b4fbc8 100644
--- a/testing/fuzzers/pdfium_fuzzer_helper.cc
+++ b/testing/fuzzers/pdfium_fuzzer_helper.cc
@@ -175,8 +175,6 @@
if (!doc)
return;
- (void)FPDF_GetDocPermissions(doc.get());
-
ScopedFPDFFormHandle form(
FPDFDOC_InitFormFillEnvironment(doc.get(), &form_callbacks));
if (!OnFormFillEnvLoaded(doc.get()))
