tree 75a320be6e941ff510d1ab3c4e2b4ec8ea26bbc4
parent 24c6be6924df3ff585bb63f6aed4e2c81e791fb2
author Lei Zhang <thestig@chromium.org> 1707424600 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1707424600 +0000

Fix PDF loading when an initial xref stream references a xref table

In CPDF_Parser, LoadAllCrossRefV4() will try to call LoadCrossRefV5() if
LoadCrossRefV4() fails for secondary xref data. However,
LoadAllCrossRefV5() only calls LoadCrossRefV5(). As a result, if
LoadAllCrossRefV5() only knows how to handle cross reference streams,
and fails if it ever encounters a cross reference table. Update
LoadAllCrossRefV5() to call LoadCrossRefV4() if LoadCrossRefV5() fails.
Then unsuppress the pixel test that renders correctly as a result of
this fix.

Along the way, fix some nits for how CPDF_Dictionary variables in
CPDF_Parser are named and assigned to.

Bug: pdfium:2123
Change-Id: Id77056b459dcd58864e34821940e73a29caed927
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/116274
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Thomas Sepez <tsepez@google.com>