commit d8a3bc9ce941062fa4dd8cc2d03b16af402adafe
author Lei Zhang <thestig@chromium.org> Wed Oct 24 21:55:21 2018 +0000
committer Chromium commit bot <commit-bot@chromium.org> Wed Oct 24 21:55:21 2018 +0000
tree 1f87a6c3b4b77738c5cf7ec7a16101b82f731eff
parent 9cbc37b4a5bfb3932e5f9a50c552d7b913178337

Use ASSERT() consistently. Replace assert() usage.

ASSERT() is PDFium's wrapper for cross-platform wrapper for assert().

Change-Id: Ie2a98a8e1de101f93aa9bf667d6f125d11d129cd
Reviewed-on: https://pdfium-review.googlesource.com/c/44539
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

core/fpdfapi/page/cpdf_docpagedata.cpp

diff --git a/core/fpdfapi/page/cpdf_docpagedata.cpp b/core/fpdfapi/page/cpdf_docpagedata.cpp
index 2cb87e7..7b62467 100644
--- a/core/fpdfapi/page/cpdf_docpagedata.cpp
+++ b/core/fpdfapi/page/cpdf_docpagedata.cpp
@@ -30,7 +30,7 @@
 
 CPDF_DocPageData::CPDF_DocPageData(CPDF_Document* pPDFDoc)
     : m_bForceClear(false), m_pPDFDoc(pPDFDoc) {
-  assert(m_pPDFDoc);
+  ASSERT(m_pPDFDoc);
 }
 
 CPDF_DocPageData::~CPDF_DocPageData() {

core/fpdfapi/page/cpdf_shadingpattern.cpp

diff --git a/core/fpdfapi/page/cpdf_shadingpattern.cpp b/core/fpdfapi/page/cpdf_shadingpattern.cpp
index 79ea6f8..bb0291d 100644
--- a/core/fpdfapi/page/cpdf_shadingpattern.cpp
+++ b/core/fpdfapi/page/cpdf_shadingpattern.cpp
@@ -33,7 +33,7 @@
     : CPDF_Pattern(pDoc, bShading ? nullptr : pPatternObj, parentMatrix),
       m_bShadingObj(bShading),
       m_pShadingObj(pPatternObj) {
-  assert(document());
+  ASSERT(document());
   if (!bShading) {
     m_pShadingObj = pattern_obj()->GetDict()->GetDirectObjectFor("Shading");
     SetPatternToFormMatrix();

core/fpdfapi/page/cpdf_tilingpattern.cpp

diff --git a/core/fpdfapi/page/cpdf_tilingpattern.cpp b/core/fpdfapi/page/cpdf_tilingpattern.cpp
index 3cbfa07..faa7eb8 100644
--- a/core/fpdfapi/page/cpdf_tilingpattern.cpp
+++ b/core/fpdfapi/page/cpdf_tilingpattern.cpp
@@ -16,7 +16,7 @@
                                        CPDF_Object* pPatternObj,
                                        const CFX_Matrix& parentMatrix)
     : CPDF_Pattern(pDoc, pPatternObj, parentMatrix) {
-  assert(document());
+  ASSERT(document());
   m_bColored = pattern_obj()->GetDict()->GetIntegerFor("PaintType") == 1;
   SetPatternToFormMatrix();
 }

fxbarcode/oned/BC_OnedCode128Writer.cpp

diff --git a/fxbarcode/oned/BC_OnedCode128Writer.cpp b/fxbarcode/oned/BC_OnedCode128Writer.cpp
index ad94d29..7a16280 100644
--- a/fxbarcode/oned/BC_OnedCode128Writer.cpp
+++ b/fxbarcode/oned/BC_OnedCode128Writer.cpp
@@ -78,7 +78,7 @@
 
 CBC_OnedCode128Writer::CBC_OnedCode128Writer(BC_TYPE type)
     : m_codeFormat(type) {
-  assert(m_codeFormat == BC_CODE128_B || m_codeFormat == BC_CODE128_C);
+  ASSERT(m_codeFormat == BC_CODE128_B || m_codeFormat == BC_CODE128_C);
 }
 
 CBC_OnedCode128Writer::~CBC_OnedCode128Writer() = default;

fxbarcode/pdf417/BC_PDF417ErrorCorrection.cpp

diff --git a/fxbarcode/pdf417/BC_PDF417ErrorCorrection.cpp b/fxbarcode/pdf417/BC_PDF417ErrorCorrection.cpp
index ade3eb5..4ca40ef 100644
--- a/fxbarcode/pdf417/BC_PDF417ErrorCorrection.cpp
+++ b/fxbarcode/pdf417/BC_PDF417ErrorCorrection.cpp
@@ -135,8 +135,8 @@
     const WideString& dataCodewords,
     int32_t errorCorrectionLevel,
     WideString* result) {
-  assert(result);
-  assert(result->IsEmpty());
+  ASSERT(result);
+  ASSERT(result->IsEmpty());
 
   int32_t k = getErrorCorrectionCodewordCount(errorCorrectionLevel);
   if (k < 0)

xfa/fxfa/parser/cxfa_nodeowner.cpp

diff --git a/xfa/fxfa/parser/cxfa_nodeowner.cpp b/xfa/fxfa/parser/cxfa_nodeowner.cpp
index ae6f589..13c969c 100644
--- a/xfa/fxfa/parser/cxfa_nodeowner.cpp
+++ b/xfa/fxfa/parser/cxfa_nodeowner.cpp
@@ -30,6 +30,6 @@
 
   pdfium::FakeUniquePtr<CXFA_Node> search(node);
   auto it = nodes_.find(search);
-  assert(it != nodes_.end());
+  ASSERT(it != nodes_.end());
   nodes_.erase(it);
 }