)]}'
{
  "commit": "db4d331e7fd0f85e13eddbad4737fd9604051cba",
  "tree": "86f9811281a335cb4ad3d55bcd960bd6a98a1590",
  "parents": [
    "5b79f16efda33d168d15b9b739ab789cf4841b2e"
  ],
  "author": {
    "name": "Hui Yingst",
    "email": "nigi@chromium.org",
    "time": "Thu Sep 19 18:02:30 2019 +0000"
  },
  "committer": {
    "name": "Chromium commit bot",
    "email": "commit-bot@chromium.org",
    "time": "Thu Sep 19 18:02:30 2019 +0000"
  },
  "message": "[SkiaPaths] Vertical texts were drawn in reversed direction.\n\nIn ChS_simple.pdf, the Chinese characters are displayed vertically and\nwhen characters are displayed in order, the sentence direction was\ngoing upwards instead of downwards. This is because when the main font\nindicates vertical display (\"Identity-V\"), its descendant font should\ninherit the vertical setup since there is only one way to display the\ntext object. LoadSubstFont() is the only method to sync the descendant\nfont\u0027s |m_bVertical| with the main font, but it was skipped in\nCPDF_CIDFont::Load() due to the main font is embedded.\n\nTo fix this issue, need to add a step to sync the descendant font\u0027s\n|m_bVertical| value with the main font if it indicates vertical\ndisplay (not default value), regardless whether the main font is\nembedded or not. Also this CL calls LoadFontDescriptor() after\n|m_pCMap| is initialized to make sure IsVertWriting() returns the\ncorrect value.\n\nBug: pdfium:1376\nChange-Id: I7e935b59745b063b82ec709afd847c6bc289937d\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/58611\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "6a9e4fcce90e9e7c8f23d7b11d422b6527aece3c",
      "old_mode": 33188,
      "old_path": "core/fpdfapi/font/cpdf_cidfont.cpp",
      "new_id": "e4128ea02e585174aab1920433713cbb0cb73d81",
      "new_mode": 33188,
      "new_path": "core/fpdfapi/font/cpdf_cidfont.cpp"
    },
    {
      "type": "modify",
      "old_id": "4b1ddcc18b059b544b5e9d4a41a4bf20efd7ae49",
      "old_mode": 33188,
      "old_path": "core/fpdfapi/font/cpdf_font.cpp",
      "new_id": "089d61c055b105da3fcb16801a9b7b3761d647fb",
      "new_mode": 33188,
      "new_path": "core/fpdfapi/font/cpdf_font.cpp"
    },
    {
      "type": "modify",
      "old_id": "fc33e209a1624a6672834eb14856149b8988e915",
      "old_mode": 33188,
      "old_path": "core/fxge/cfx_font.cpp",
      "new_id": "1989c2e204c95996344f0e79d2a2557949abd0ea",
      "new_mode": 33188,
      "new_path": "core/fxge/cfx_font.cpp"
    },
    {
      "type": "modify",
      "old_id": "c28ce5e1241f4f03df968d226aa5ba5a651f0e53",
      "old_mode": 33188,
      "old_path": "core/fxge/cfx_font.h",
      "new_id": "57cc8f850d2a6f9cb600a8bc708ca8667e218ecc",
      "new_mode": 33188,
      "new_path": "core/fxge/cfx_font.h"
    },
    {
      "type": "modify",
      "old_id": "9ed56011d3ca17e2e52ea649c72af16408a83690",
      "old_mode": 33188,
      "old_path": "fpdfsdk/fpdf_edittext.cpp",
      "new_id": "5d19781d23360eff2b162486753c971480dd1cf1",
      "new_mode": 33188,
      "new_path": "fpdfsdk/fpdf_edittext.cpp"
    }
  ]
}