commit e0a5f1a9c7b74d1f29496782592500d0890835f7
author Lei Zhang <thestig@chromium.org> Thu Nov 14 00:09:13 2019 +0000
committer Chromium commit bot <commit-bot@chromium.org> Thu Nov 14 00:09:13 2019 +0000
tree ea76af2c222bab2cbe5e8caa1d358b3f54699e3d
parent 96befae824837fbad3f164c602961756c7b0b1db

Fix nits in FPDFEditPathEmbedderTest.

- Use a constant for the object count.
- Correctly use ASSERT_TRUE() instead of ASSERT().
- Check a couple more return values.

Change-Id: Ibe8d172804084bb59bdd0da8f2c8e2ea32c35c60
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/62356
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

fpdfsdk/fpdf_editpath_embeddertest.cpp

diff --git a/fpdfsdk/fpdf_editpath_embeddertest.cpp b/fpdfsdk/fpdf_editpath_embeddertest.cpp
index 7bd5ae2..2a8fb6a 100644
--- a/fpdfsdk/fpdf_editpath_embeddertest.cpp
+++ b/fpdfsdk/fpdf_editpath_embeddertest.cpp
@@ -10,10 +10,11 @@
 class FPDFEditPathEmbedderTest : public EmbedderTest {};
 
 TEST_F(FPDFEditPathEmbedderTest, VerifyCorrectColoursReturned) {
+  constexpr int kObjectCount = 256;
   CreateEmptyDocument();
   FPDF_PAGE page = FPDFPage_New(document(), 0, 612, 792);
 
-  for (size_t i = 0; i < 256; ++i) {
+  for (size_t i = 0; i < kObjectCount; ++i) {
     FPDF_PAGEOBJECT path = FPDFPageObj_CreateNewPath(400, 100);
     EXPECT_TRUE(FPDFPageObj_SetFillColor(path, i, i, i, i));
     EXPECT_TRUE(FPDFPageObj_SetStrokeColor(path, i, i, i, i));
@@ -34,9 +35,9 @@
   page = LoadSavedPage(0);
   ASSERT(page);
 
-  for (size_t i = 0; i < 256; ++i) {
+  for (size_t i = 0; i < kObjectCount; ++i) {
     FPDF_PAGEOBJECT path = FPDFPage_GetObject(page, i);
-    ASSERT(path);
+    ASSERT_TRUE(path);
 
     EXPECT_EQ(FPDF_PAGEOBJ_PATH, FPDFPageObj_GetType(path));
 
@@ -44,13 +45,13 @@
     unsigned int g;
     unsigned int b;
     unsigned int a;
-    FPDFPageObj_GetFillColor(path, &r, &g, &b, &a);
+    ASSERT_TRUE(FPDFPageObj_GetFillColor(path, &r, &g, &b, &a));
     EXPECT_EQ(i, r);
     EXPECT_EQ(i, g);
     EXPECT_EQ(i, b);
     EXPECT_EQ(i, a);
 
-    FPDFPageObj_GetStrokeColor(path, &r, &g, &b, &a);
+    ASSERT_TRUE(FPDFPageObj_GetStrokeColor(path, &r, &g, &b, &a));
     EXPECT_EQ(i, r);
     EXPECT_EQ(i, g);
     EXPECT_EQ(i, b);