commit e1ea608510873331b52131330bff352c6d6e4ae7
author Lei Zhang <thestig@chromium.org> Wed Nov 14 23:07:08 2018 +0000
committer Chromium commit bot <commit-bot@chromium.org> Wed Nov 14 23:07:08 2018 +0000
tree a1cffc8f8076fae12e70abe49933e9467ef0d4c3
parent 1399a22912fa38b0d5af2532cd0b37b0b3951d50

Slightly simplify CPDF_FontEncoding::Realize().

Change-Id: I24ebe3ab8154c90e193068b5b8c10e6fb590416d
Reviewed-on: https://pdfium-review.googlesource.com/c/45532
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

core/fpdfapi/font/cpdf_fontencoding.cpp

diff --git a/core/fpdfapi/font/cpdf_fontencoding.cpp b/core/fpdfapi/font/cpdf_fontencoding.cpp
index b5e254a..7c63d13 100644
--- a/core/fpdfapi/font/cpdf_fontencoding.cpp
+++ b/core/fpdfapi/font/cpdf_fontencoding.cpp
@@ -1700,19 +1700,17 @@
     }
   }
   if (predefined) {
-    if (predefined == PDFFONT_ENCODING_WINANSI) {
-      return pdfium::MakeUnique<CPDF_Name>(pHolder->GetByteStringPool(),
-                                           "WinAnsiEncoding");
-    }
-    if (predefined == PDFFONT_ENCODING_MACROMAN) {
-      return pdfium::MakeUnique<CPDF_Name>(pHolder->GetByteStringPool(),
-                                           "MacRomanEncoding");
-    }
-    if (predefined == PDFFONT_ENCODING_MACEXPERT) {
-      return pdfium::MakeUnique<CPDF_Name>(pHolder->GetByteStringPool(),
-                                           "MacExpertEncoding");
-    }
-    return nullptr;
+    const char* pName;
+    if (predefined == PDFFONT_ENCODING_WINANSI)
+      pName = "WinAnsiEncoding";
+    else if (predefined == PDFFONT_ENCODING_MACROMAN)
+      pName = "MacRomanEncoding";
+    else if (predefined == PDFFONT_ENCODING_MACEXPERT)
+      pName = "MacExpertEncoding";
+    else
+      return nullptr;
+
+    return pdfium::MakeUnique<CPDF_Name>(pHolder->GetByteStringPool(), pName);
   }
   const uint16_t* pStandard =
       PDF_UnicodesForPredefinedCharSet(PDFFONT_ENCODING_WINANSI);