)]}'
{
  "commit": "e3379209d2ab58ffeb91e889e5bfb119fdb7a4c8",
  "tree": "94ed5f1282794893647f41873d733edc8a970069",
  "parents": [
    "1111764c3496c30ae65a4ec71286f90a8da437cd"
  ],
  "author": {
    "name": "Hui Yingst",
    "email": "nigi@chromium.org",
    "time": "Thu Jan 09 00:59:26 2020 +0000"
  },
  "committer": {
    "name": "Chromium commit bot",
    "email": "commit-bot@chromium.org",
    "time": "Thu Jan 09 00:59:26 2020 +0000"
  },
  "message": "Change StringToCode() to return Optional\u003cuint32_t\u003e type.\n\nThis CL changes StringToCode() to return Optional\u003cuint32_t\u003e type, so\nthat pdfium::nullopt can be used as the return value to indicate\ninvalid string, since Acrobat allows character codes which cover the\nwhole uint32_t range. Right now this CL treats pdfium::nullopt as 0\nto avoid behavior changes. A future CL will handle return value 0\ndifferently (as a valid value).\n\nBug: pdfium:1422\nChange-Id: I91db0d010eef5102b67ac2fb0a0118368a83a5d7\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/64510\nCommit-Queue: Hui Yingst \u003cnigi@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "b27543449cd3d9072a7fe80ae6b24f78265670ef",
      "old_mode": 33188,
      "old_path": "core/fpdfapi/font/cpdf_tounicodemap.cpp",
      "new_id": "acef5e4399c86fc4adec9e714c18c0f04baa8221",
      "new_mode": 33188,
      "new_path": "core/fpdfapi/font/cpdf_tounicodemap.cpp"
    },
    {
      "type": "modify",
      "old_id": "e3d04ed48c005be5592b4a0b533de6adefe189bb",
      "old_mode": 33188,
      "old_path": "core/fpdfapi/font/cpdf_tounicodemap.h",
      "new_id": "9eaf625e1c29826ccbecfa671b6abbd2812af6fc",
      "new_mode": 33188,
      "new_path": "core/fpdfapi/font/cpdf_tounicodemap.h"
    },
    {
      "type": "modify",
      "old_id": "bca94f3b62ef9ad9259bbbfde7613170674758b8",
      "old_mode": 33188,
      "old_path": "core/fpdfapi/font/cpdf_tounicodemap_unittest.cpp",
      "new_id": "891fa0835e48ba691aeb86b528beb17beac04711",
      "new_mode": 33188,
      "new_path": "core/fpdfapi/font/cpdf_tounicodemap_unittest.cpp"
    }
  ]
}
