commit edf283e098e56b72e1941e00e04b7045d9742c5f
author Tom Sepez <tsepez@chromium.org> Fri Sep 03 22:43:23 2021 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Sep 03 22:43:23 2021 +0000
tree 8b49a0e91caae47764c67c9c096d271033694e50
parent ca782b9c47bb6aaf1e612f008e2c66ea4045b071

Remove CPDF_StreamContentParser::m_pLastTextObject.

It is set in one place, but never used, and as an unowned reference
the lifetime is not affected.

Change-Id: Iff91d8a5fbfdfb3b77d834a35843428770cd666a
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/84771
Reviewed-by: Hui Yingst <nigi@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

core/fpdfapi/page/cpdf_streamcontentparser.cpp

diff --git a/core/fpdfapi/page/cpdf_streamcontentparser.cpp b/core/fpdfapi/page/cpdf_streamcontentparser.cpp
index b09f0b1..112d457 100644
--- a/core/fpdfapi/page/cpdf_streamcontentparser.cpp
+++ b/core/fpdfapi/page/cpdf_streamcontentparser.cpp
@@ -1234,7 +1234,6 @@
                            : m_pCurStates->m_TextState.GetTextMode();
   {
     auto pText = std::make_unique<CPDF_TextObject>(GetCurrentStreamIndex());
-    m_pLastTextObject = pText.get();
     SetGraphicStates(pText.get(), true, true, true);
     if (TextRenderingModeIsStrokeMode(text_mode)) {
       pdfium::span<float> pCTM = pText->m_TextState.GetMutableCTM();

core/fpdfapi/page/cpdf_streamcontentparser.h

diff --git a/core/fpdfapi/page/cpdf_streamcontentparser.h b/core/fpdfapi/page/cpdf_streamcontentparser.h
index 3c82d3d..70de6fa 100644
--- a/core/fpdfapi/page/cpdf_streamcontentparser.h
+++ b/core/fpdfapi/page/cpdf_streamcontentparser.h
@@ -230,7 +230,6 @@
   std::unique_ptr<CPDF_AllStates> m_pCurStates;
   std::stack<std::unique_ptr<CPDF_ContentMarks>> m_ContentMarksStack;
   std::vector<std::unique_ptr<CPDF_TextObject>> m_ClipTextList;
-  UnownedPtr<const CPDF_TextObject> m_pLastTextObject;
   std::vector<CFX_Path::Point> m_PathPoints;
   CFX_PointF m_PathStart;
   CFX_PointF m_PathCurrent;