Cleanup fx_coordinates_unittest.cpp Test using rect constructor with no args was not testing the result of the GetOuterRect(), but just comparing the default values from CFX_FloatRect() constructor. Fix that by checking |outer_rect|. Bug: chromium:1019026 Change-Id: Ic5d7fc704559808d6ebdbbbc0d5de6784f36447f Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/63157 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org>
diff --git a/core/fxcrt/fx_coordinates_unittest.cpp b/core/fxcrt/fx_coordinates_unittest.cpp index cd26ed5..b90bb8d 100644 --- a/core/fxcrt/fx_coordinates_unittest.cpp +++ b/core/fxcrt/fx_coordinates_unittest.cpp
@@ -84,10 +84,10 @@ constexpr float kMaxIntAsFloat = static_cast<float>(kMaxInt); outer_rect = rect.GetOuterRect(); - EXPECT_EQ(0, rect.left); - EXPECT_EQ(0, rect.bottom); - EXPECT_EQ(0, rect.right); - EXPECT_EQ(0, rect.top); + EXPECT_EQ(0, outer_rect.left); + EXPECT_EQ(0, outer_rect.bottom); + EXPECT_EQ(0, outer_rect.right); + EXPECT_EQ(0, outer_rect.top); // Function converts from float to int using floor() for left and top, and // ceil() for right and bottom.