tree 830a16dd30c6182fd235a5ef95770538b4ec1ec6
parent e782e37b182c767925a750dfad5aa8fe979936b4
author Hui Yingst <nigi@chromium.org> 1589242953 +0000
committer Chromium commit bot <commit-bot@chromium.org> 1589242953 +0000

Check whether the object is a page object before updating |m_PageList|.

bug_1491.in is rendered blank because when handling the "GoTo" action,
the destination points to an object which is a /Pages object instead
of a /Page object. This sets |m_PageList[0]| with the wrong object
which is missing contents.

This CL adds a check for valid page object before updating |m_PageList|
in CPDF_Document::GetPageIndex(), so that when processing the "GoTo"
action, |m_PageList[i]| will remain unchanged for page |i| if the
matching object number doesn't point to a /Page object. Later, during
the rendering process, CPDF_Document::GetPageDictionary() can rely on
TraversePDFPages() to update |m_PageList| with more reliable object
numbers.

Bug: pdfium:1491
Change-Id: I4e8a81c6504f52dd5e5b8cd9195c2c60d8885f94
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/69710
Commit-Queue: Hui Yingst <nigi@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>