commit fc2941fee9b69c2822e6e0e823df1cca845c0c40
author Tom Sepez <tsepez@chromium.org> Fri Sep 03 18:24:43 2021 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Sep 03 18:24:43 2021 +0000
tree cf278afdfbeb30e74b429f19d3a58dd7ed9805d6
parent df97b84326abf47450f7b3cb503cda1253312c0f

Remove unused member CPDF_TransferFunc::m_pPDFDoc.

Change-Id: Ie68550f9e3f183521cf2bb4d6975f6e8c06ec405
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/84714
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Hui Yingst <nigi@chromium.org>

core/fpdfapi/page/cpdf_transferfunc.cpp

diff --git a/core/fpdfapi/page/cpdf_transferfunc.cpp b/core/fpdfapi/page/cpdf_transferfunc.cpp
index 15d77d5..b512c6a 100644
--- a/core/fpdfapi/page/cpdf_transferfunc.cpp
+++ b/core/fpdfapi/page/cpdf_transferfunc.cpp
@@ -14,13 +14,11 @@
 #include "third_party/base/check_op.h"
 
 CPDF_TransferFunc::CPDF_TransferFunc(
-    const CPDF_Document* pDoc,
     bool bIdentify,
     std::vector<uint8_t, FxAllocAllocator<uint8_t>> samples_r,
     std::vector<uint8_t, FxAllocAllocator<uint8_t>> samples_g,
     std::vector<uint8_t, FxAllocAllocator<uint8_t>> samples_b)
-    : m_pPDFDoc(pDoc),
-      m_bIdentity(bIdentify),
+    : m_bIdentity(bIdentify),
       m_SamplesR(std::move(samples_r)),
       m_SamplesG(std::move(samples_g)),
       m_SamplesB(std::move(samples_b)) {

core/fpdfapi/page/cpdf_transferfunc.h

diff --git a/core/fpdfapi/page/cpdf_transferfunc.h b/core/fpdfapi/page/cpdf_transferfunc.h
index 28dd6c1..961684c 100644
--- a/core/fpdfapi/page/cpdf_transferfunc.h
+++ b/core/fpdfapi/page/cpdf_transferfunc.h
@@ -12,11 +12,9 @@
 #include "core/fxcrt/fx_memory_wrappers.h"
 #include "core/fxcrt/observed_ptr.h"
 #include "core/fxcrt/retain_ptr.h"
-#include "core/fxcrt/unowned_ptr.h"
 #include "core/fxge/dib/fx_dib.h"
 #include "third_party/base/span.h"
 
-class CPDF_Document;
 class CFX_DIBBase;
 
 class CPDF_TransferFunc final : public Retainable, public Observable {
@@ -28,8 +26,6 @@
   FX_COLORREF TranslateColor(FX_COLORREF colorref) const;
   RetainPtr<CFX_DIBBase> TranslateImage(const RetainPtr<CFX_DIBBase>& pSrc);
 
-  const CPDF_Document* GetDocument() const { return m_pPDFDoc.Get(); }
-
   // Spans are |kChannelSampleSize| in size.
   pdfium::span<const uint8_t> GetSamplesR() const;
   pdfium::span<const uint8_t> GetSamplesG() const;
@@ -38,14 +34,12 @@
   bool GetIdentity() const { return m_bIdentity; }
 
  private:
-  CPDF_TransferFunc(const CPDF_Document* pDoc,
-                    bool bIdentify,
+  CPDF_TransferFunc(bool bIdentify,
                     std::vector<uint8_t, FxAllocAllocator<uint8_t>> samples_r,
                     std::vector<uint8_t, FxAllocAllocator<uint8_t>> samples_g,
                     std::vector<uint8_t, FxAllocAllocator<uint8_t>> samples_b);
   ~CPDF_TransferFunc() override;
 
-  UnownedPtr<const CPDF_Document> const m_pPDFDoc;
   const bool m_bIdentity;
   const std::vector<uint8_t, FxAllocAllocator<uint8_t>> m_SamplesR;
   const std::vector<uint8_t, FxAllocAllocator<uint8_t>> m_SamplesG;

core/fpdfapi/render/cpdf_docrenderdata.cpp

diff --git a/core/fpdfapi/render/cpdf_docrenderdata.cpp b/core/fpdfapi/render/cpdf_docrenderdata.cpp
index 5e3e070..659d4b3 100644
--- a/core/fpdfapi/render/cpdf_docrenderdata.cpp
+++ b/core/fpdfapi/render/cpdf_docrenderdata.cpp
@@ -117,7 +117,7 @@
       channel[v] = o;
   }
 
-  return pdfium::MakeRetain<CPDF_TransferFunc>(
-      GetDocument(), bIdentity, std::move(samples_r), std::move(samples_g),
-      std::move(samples_b));
+  return pdfium::MakeRetain<CPDF_TransferFunc>(bIdentity, std::move(samples_r),
+                                               std::move(samples_g),
+                                               std::move(samples_b));
 }