)]}'
{
  "commit": "fe8d4e30401757ebbbbf7c8a6e0430dc9e4d5ab0",
  "tree": "b0b1f8c12b1b92ac7b0c495e5f4785edff33cbed",
  "parents": [
    "5a2ef2757c25a55012bd3e7e0647a6723e91915b"
  ],
  "author": {
    "name": "Tom Sepez",
    "email": "tsepez@chromium.org",
    "time": "Thu Aug 15 20:15:08 2019 +0000"
  },
  "committer": {
    "name": "Chromium commit bot",
    "email": "commit-bot@chromium.org",
    "time": "Thu Aug 15 20:15:08 2019 +0000"
  },
  "message": "Replace PDF_ENABLE_XFA with an interface in CFXJS_Engine.\n\nThen remove some JS calls from fpdfsdk when fxjs/xfa wants to interact\nwith fxjs/non-xfa, merely returning the reference itself. In turn,\nwe are now passing V8 locals, so the lifetime of the handle scope\nmust increase in the callers.\n\nAlso remove an ifdef from messages just to get more similarity\nbetween xfa/non-xfa at the cost of a few bytes of string.\n\nThe result is no more PDF_ENABLE_XFA in fjxs.\n\n-- Remove unused ChangeObjName().\n-- Set result to undefined at method start so early returns are safer.\n-- Always set up handle/isolate scopes prior to defining objects, even\n   though it may not be strictly required for non-xfa.\n\nChange-Id: Ie69077cca17d132122050073f15743ffdd1a4e07\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/59257\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "16fd3e1675a424df32293ef023f6601b05549a94",
      "old_mode": 33188,
      "old_path": "fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp",
      "new_id": "662af58cd95446a2f41c774658d0dd41824954f9",
      "new_mode": 33188,
      "new_path": "fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp"
    },
    {
      "type": "modify",
      "old_id": "7c86bd814b1cdf1605af7e661b34b02d230c7364",
      "old_mode": 33188,
      "old_path": "fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.h",
      "new_id": "100e664d8204de9a8185d897ff9ba416fc81f814",
      "new_mode": 33188,
      "new_path": "fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.h"
    },
    {
      "type": "modify",
      "old_id": "8c6c69c9be4fb637985bdaca4b268395b2a3d109",
      "old_mode": 33188,
      "old_path": "fxjs/cfxjs_engine.h",
      "new_id": "933c2508e91e8800f3b0f9fe47cb397fc904833d",
      "new_mode": 33188,
      "new_path": "fxjs/cfxjs_engine.h"
    },
    {
      "type": "modify",
      "old_id": "4cb37dd1e4d648965e17729d4822a600e85fdf0a",
      "old_mode": 33188,
      "old_path": "fxjs/cjs_runtime.cpp",
      "new_id": "81148de9a109bf0a6453995f565f252d4b93198c",
      "new_mode": 33188,
      "new_path": "fxjs/cjs_runtime.cpp"
    },
    {
      "type": "modify",
      "old_id": "4320c3dae9254fbfc163cc34031297c70c21e681",
      "old_mode": 33188,
      "old_path": "fxjs/cjs_runtime.h",
      "new_id": "b3f8ef68f2aa6db990dc2494d8bf6122fd63b9dc",
      "new_mode": 33188,
      "new_path": "fxjs/cjs_runtime.h"
    },
    {
      "type": "modify",
      "old_id": "0a774a5699f442e42c69cb72d553c33d76ea82d0",
      "old_mode": 33188,
      "old_path": "fxjs/cjs_runtimestub.cpp",
      "new_id": "6e313de584a6e4ab92daacb0af91adaf81364fc6",
      "new_mode": 33188,
      "new_path": "fxjs/cjs_runtimestub.cpp"
    },
    {
      "type": "modify",
      "old_id": "a702b7738b58f059ac0e6c0fb7ea70fa84782ade",
      "old_mode": 33188,
      "old_path": "fxjs/cjs_runtimestub.h",
      "new_id": "2b5e71349dd9195e0d249b8406f0e8174e5f6268",
      "new_mode": 33188,
      "new_path": "fxjs/cjs_runtimestub.h"
    },
    {
      "type": "modify",
      "old_id": "2d879f69bc258936b2b5e3bb9eee2b18a8c2e458",
      "old_mode": 33188,
      "old_path": "fxjs/ijs_runtime.h",
      "new_id": "ca103aa9a46110f97c4b3469b17b9c374a423768",
      "new_mode": 33188,
      "new_path": "fxjs/ijs_runtime.h"
    },
    {
      "type": "modify",
      "old_id": "16df281dbf94fbe12a5b3e938a9ac26bddd60f68",
      "old_mode": 33188,
      "old_path": "fxjs/js_resources.cpp",
      "new_id": "3bc8df3756dacb6cadedcd27b36c9ad8147f2acb",
      "new_mode": 33188,
      "new_path": "fxjs/js_resources.cpp"
    },
    {
      "type": "modify",
      "old_id": "a95e1b3096121248f5368d229e055f18af6358b6",
      "old_mode": 33188,
      "old_path": "fxjs/js_resources.h",
      "new_id": "8a308628847a818cbb92fcd7155843e942938a50",
      "new_mode": 33188,
      "new_path": "fxjs/js_resources.h"
    },
    {
      "type": "modify",
      "old_id": "8dafcb3f08da4f5d65b11c17a18c189c2f75ae90",
      "old_mode": 33188,
      "old_path": "fxjs/xfa/cfxjse_engine.cpp",
      "new_id": "7ac440d0a231a88e85bc5fa27290a7c3fc544724",
      "new_mode": 33188,
      "new_path": "fxjs/xfa/cfxjse_engine.cpp"
    },
    {
      "type": "modify",
      "old_id": "fdff67a584afee75aed27d95b74b1ad03fefe78d",
      "old_mode": 33188,
      "old_path": "fxjs/xfa/cfxjse_runtimedata.cpp",
      "new_id": "0478e3e6ca07e0fbcecd558719321f33ec00e528",
      "new_mode": 33188,
      "new_path": "fxjs/xfa/cfxjse_runtimedata.cpp"
    },
    {
      "type": "modify",
      "old_id": "c0f5da35cdc09605056bd6110c1d1a4066c616e7",
      "old_mode": 33188,
      "old_path": "fxjs/xfa/cfxjse_runtimedata.h",
      "new_id": "148b01ec0c2947fc07a3dee59b37e5e6bd1d9156",
      "new_mode": 33188,
      "new_path": "fxjs/xfa/cfxjse_runtimedata.h"
    },
    {
      "type": "modify",
      "old_id": "350e0e4f3f1d47cbbd7a48b0baf9414dcd1b059c",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/fxfa.h",
      "new_id": "9193d1ba3c2d1d79398a3ce874d0842885b98027",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/fxfa.h"
    }
  ]
}