)]}' { "commit": "ffff6c5fcc92d076e001463f8b30ee60d68f30f1", "tree": "3325b819173a026ff37c846613fec46404dd3b70", "parents": [ "12bc1c4dae87f210dc1b379d658a7f329c74d469" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Tue Jul 30 21:56:19 2019 +0000" }, "committer": { "name": "Chromium commit bot", "email": "commit-bot@chromium.org", "time": "Tue Jul 30 21:56:19 2019 +0000" }, "message": "Make CPDF_Font a retainable type.\n\nIn turn, this makes CPDF_CountedObject\u003c\u003e unused, so remove it.\n\nWe have to explicitly break some cycles between fonts and forms,\nso introduce a WillBeDestroyed() method.\n\nThis also introduces the requirement that callers of\nFPDFText_LoadStandardFont() release the resource via a call\nto FPDFFont_Close().\n\n\nChange-Id: I27451a24e55424e7f784a1af962036269295aed2\nReviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/57470\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "16676fe5bae3089024942ea4ccf10509c5d472b4", "old_mode": 33188, "old_path": "core/fpdfapi/edit/cpdf_pagecontentgenerator.cpp", "new_id": "984569e8732618699454d3e706a8989429167e4b", "new_mode": 33188, "new_path": "core/fpdfapi/edit/cpdf_pagecontentgenerator.cpp" }, { "type": "modify", "old_id": "d997420df4d015b2daf226f65f8244d70e8a3f97", "old_mode": 33188, "old_path": "core/fpdfapi/edit/cpdf_pagecontentgenerator_unittest.cpp", "new_id": "a2ee17a6a150f5c834b77174559d876c6e23c929", "new_mode": 33188, "new_path": "core/fpdfapi/edit/cpdf_pagecontentgenerator_unittest.cpp" }, { "type": "modify", "old_id": "235f38c82cf640c107a1ef94c2578db81150191d", "old_mode": 33188, "old_path": "core/fpdfapi/font/cfx_stockfontarray.cpp", "new_id": "2c3bca4924d4a422da98ce18300c2110fe766bcc", "new_mode": 33188, "new_path": "core/fpdfapi/font/cfx_stockfontarray.cpp" }, { "type": "modify", "old_id": "d5a873921d2ddeb8051ec7d910a5cfb16034103a", "old_mode": 33188, "old_path": "core/fpdfapi/font/cfx_stockfontarray.h", "new_id": "5e5470430a899f516b6c92d503fcedd84378049e", "new_mode": 33188, "new_path": "core/fpdfapi/font/cfx_stockfontarray.h" }, { "type": "modify", "old_id": "e40085909b35e732c95660372eac9a1ed3dc6075", "old_mode": 33188, "old_path": "core/fpdfapi/font/cpdf_cidfont.h", "new_id": "ea97f26770a7cbd5a913e6d893e4541e6f4c94fa", "new_mode": 33188, "new_path": "core/fpdfapi/font/cpdf_cidfont.h" }, { "type": "modify", "old_id": "563ee3097d3107c77cd2171207ac0e7b4d89848d", "old_mode": 33188, "old_path": "core/fpdfapi/font/cpdf_cidfont_unittest.cpp", "new_id": "f8d368045fe609bf96d3b58ea4d68ee2e0757b25", "new_mode": 33188, "new_path": "core/fpdfapi/font/cpdf_cidfont_unittest.cpp" }, { "type": "modify", "old_id": "baac1d35cbd2b6ca323cf9e674cefe6975271ed0", "old_mode": 33188, "old_path": "core/fpdfapi/font/cpdf_font.cpp", "new_id": "4a22d73937b2f2c25418a93719ea2e07007d9f56", "new_mode": 33188, "new_path": "core/fpdfapi/font/cpdf_font.cpp" }, { "type": "modify", "old_id": "1a1d361ca969b7d74829316c7d9b6459a61bc9b6", "old_mode": 33188, "old_path": "core/fpdfapi/font/cpdf_font.h", "new_id": "028fb3e0f673df3349115c009c37a76877376cd1", "new_mode": 33188, "new_path": "core/fpdfapi/font/cpdf_font.h" }, { "type": "modify", "old_id": "f4350ebf5b6d6d277621a114226a31b37dd41d91", "old_mode": 33188, "old_path": "core/fpdfapi/font/cpdf_fontglobals.cpp", "new_id": "e3b19e2065831a2dfaa201fbe7b27ccfc9288950", "new_mode": 33188, "new_path": "core/fpdfapi/font/cpdf_fontglobals.cpp" }, { "type": "modify", "old_id": "6ae9064ae0a699a5d06a09e73887daf0f0643512", "old_mode": 33188, "old_path": "core/fpdfapi/font/cpdf_fontglobals.h", "new_id": "ff3449e07ebcb9fe04ee99340df049b1f5cb2743", "new_mode": 33188, "new_path": "core/fpdfapi/font/cpdf_fontglobals.h" }, { "type": "modify", "old_id": "290016bc49c47727e823294bdf2516695087b421", "old_mode": 33188, "old_path": "core/fpdfapi/font/cpdf_simplefont.h", "new_id": "8c909abfeb934c667e239939f798bd6efa746c98", "new_mode": 33188, "new_path": "core/fpdfapi/font/cpdf_simplefont.h" }, { "type": "modify", "old_id": "158a5df85cc0672e595821f5efec69cca2742590", "old_mode": 33188, "old_path": "core/fpdfapi/font/cpdf_truetypefont.h", "new_id": "caa16251970178e709a2ae6acd921a2d713fccb3", "new_mode": 33188, "new_path": "core/fpdfapi/font/cpdf_truetypefont.h" }, { "type": "modify", "old_id": "eb01ec716a2c1fe07636f0986bab577371f1aea1", "old_mode": 33188, "old_path": "core/fpdfapi/font/cpdf_type1font.h", "new_id": "79dfe31df7068c94d023f92a37a60b0440f8f6e4", "new_mode": 33188, "new_path": "core/fpdfapi/font/cpdf_type1font.h" }, { "type": "modify", "old_id": "1bf5ebb3a51f75b1a513beed122b92b0590b9a1f", "old_mode": 33188, "old_path": "core/fpdfapi/font/cpdf_type3char.cpp", "new_id": "7d71e8c44e6305fbcaaa190b0f80fc5cfc1053ab", "new_mode": 33188, "new_path": "core/fpdfapi/font/cpdf_type3char.cpp" }, { "type": "modify", "old_id": "05ade5f80065036b6f69a08069c74f9bf0829aeb", "old_mode": 33188, "old_path": "core/fpdfapi/font/cpdf_type3char.h", "new_id": "ca8345206fdb0bfc71c24fde14611a452fa185f5", "new_mode": 33188, "new_path": "core/fpdfapi/font/cpdf_type3char.h" }, { "type": "modify", "old_id": "9983f8a3537a0d43a9addf54cb1f654d82136771", "old_mode": 33188, "old_path": "core/fpdfapi/font/cpdf_type3font.cpp", "new_id": "7e2e59d5ce3b82d0ec6fc2a712f961097ec9816f", "new_mode": 33188, "new_path": "core/fpdfapi/font/cpdf_type3font.cpp" }, { "type": "modify", "old_id": "68e0e9278506d7c8548043e7b846d6cac2c7542e", "old_mode": 33188, "old_path": "core/fpdfapi/font/cpdf_type3font.h", "new_id": "1ef469bb694fdf1c5ee99b961ed7586a4b3fa279", "new_mode": 33188, "new_path": "core/fpdfapi/font/cpdf_type3font.h" }, { "type": "modify", "old_id": "edb73b89c9e650dc77e3722e7fc5ac7a97b4efe6", "old_mode": 33188, "old_path": "core/fpdfapi/page/BUILD.gn", "new_id": "5bb811557e57040d3c54f399b9d97ea6fe8d1899", "new_mode": 33188, "new_path": "core/fpdfapi/page/BUILD.gn" }, { "type": "modify", "old_id": "2485a067ca583bee78e3920c31fb0e0982ec605f", "old_mode": 33188, "old_path": "core/fpdfapi/page/cpdf_allstates.cpp", "new_id": "a12ce33dd2e0abcae6745a88e7b34b86f0fd720c", "new_mode": 33188, "new_path": "core/fpdfapi/page/cpdf_allstates.cpp" }, { "type": "delete", "old_id": "cb39616f2bbfe151ac8f627b85488a42d61090bb", "old_mode": 33188, "old_path": "core/fpdfapi/page/cpdf_countedobject.h", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "modify", "old_id": "c4309a9fe27936db9e30662e9ee0f0161ad174b1", "old_mode": 33188, "old_path": "core/fpdfapi/page/cpdf_dibbase.h", "new_id": "0e1da42454c0f9ee9f7ff0994eb65d9ae6e47517", "new_mode": 33188, "new_path": "core/fpdfapi/page/cpdf_dibbase.h" }, { "type": "modify", "old_id": "b727a79d80e6440c8079cb31e1265d0e1c2b5247", "old_mode": 33188, "old_path": "core/fpdfapi/page/cpdf_docpagedata.cpp", "new_id": "908f081a3d0d4afbedb33e93371b9c65edcca620", "new_mode": 33188, "new_path": "core/fpdfapi/page/cpdf_docpagedata.cpp" }, { "type": "modify", "old_id": "10eed18c4c01d6333a3b0101f8dfb15f0c1c47c4", "old_mode": 33188, "old_path": "core/fpdfapi/page/cpdf_docpagedata.h", "new_id": "bb9059cce1ff13dfbc1cbf33436901e46f5db4d5", "new_mode": 33188, "new_path": "core/fpdfapi/page/cpdf_docpagedata.h" }, { "type": "modify", "old_id": "c4021d87b9896d8f10a74d18afacd62cfe1154e7", "old_mode": 33188, "old_path": "core/fpdfapi/page/cpdf_streamcontentparser.cpp", "new_id": "8885760a7dc8ec50c824613fec1793c7fac35d05", "new_mode": 33188, "new_path": "core/fpdfapi/page/cpdf_streamcontentparser.cpp" }, { "type": "modify", "old_id": "a20dbe1376aabfabd6a59b3733cf3b780d2f29ea", "old_mode": 33188, "old_path": "core/fpdfapi/page/cpdf_streamcontentparser.h", "new_id": "cd47938325e20a4d8b45184fa4e3bdab51be6fac", "new_mode": 33188, "new_path": "core/fpdfapi/page/cpdf_streamcontentparser.h" }, { "type": "modify", "old_id": "c554113f22ebdaf10d148959fe8607a38b747e52", "old_mode": 33188, "old_path": "core/fpdfapi/page/cpdf_textobject.cpp", "new_id": "49d6a691754007db6a0763b6beaac23962da1eae", "new_mode": 33188, "new_path": "core/fpdfapi/page/cpdf_textobject.cpp" }, { "type": "modify", "old_id": "076dcbb72bdc3222fe7fe1fad28f96baf8a5df9b", "old_mode": 33188, "old_path": "core/fpdfapi/page/cpdf_textobject.h", "new_id": "129a0fe90bc9d25da84f68da653284bd88f71fab", "new_mode": 33188, "new_path": "core/fpdfapi/page/cpdf_textobject.h" }, { "type": "modify", "old_id": "a72594c6eb4bc264f94efd58413da790bf207d50", "old_mode": 33188, "old_path": "core/fpdfapi/page/cpdf_textstate.cpp", "new_id": "8b653321a40daf0e65da29dba0e1c17f5856c9c4", "new_mode": 33188, "new_path": "core/fpdfapi/page/cpdf_textstate.cpp" }, { "type": "modify", "old_id": "a466db6e3448be36b85f977cc00d8c6517aab828", "old_mode": 33188, "old_path": "core/fpdfapi/page/cpdf_textstate.h", "new_id": "53934ec77efb906b4498905041fcdb61c653317a", "new_mode": 33188, "new_path": "core/fpdfapi/page/cpdf_textstate.h" }, { "type": "modify", "old_id": "bbea4e34d8782c052bd4a925f3a7f9cbb4436cf7", "old_mode": 33188, "old_path": "core/fpdfapi/render/cpdf_renderstatus.cpp", "new_id": "00e30089297c3ac8010deccea031a124c7f45c94", "new_mode": 33188, "new_path": "core/fpdfapi/render/cpdf_renderstatus.cpp" }, { "type": "modify", "old_id": "34114166c1e3eb432bbfc8b87804c53312d0184e", "old_mode": 33188, "old_path": "core/fpdfapi/render/cpdf_type3cache.cpp", "new_id": "078bec79b81c468ba2b7f57fed937cee65663344", "new_mode": 33188, "new_path": "core/fpdfapi/render/cpdf_type3cache.cpp" }, { "type": "modify", "old_id": "1717e8a29994e2f96664a169f6d6a2e98a99387d", "old_mode": 33188, "old_path": "core/fpdfapi/render/cpdf_type3cache.h", "new_id": "4371a015d006e1842482ed36fee20e88793f5b61", "new_mode": 33188, "new_path": "core/fpdfapi/render/cpdf_type3cache.h" }, { "type": "modify", "old_id": "b4f737ee3df6f928740323cb2ff08b754622e180", "old_mode": 33188, "old_path": "core/fpdfdoc/cba_fontmap.cpp", "new_id": "974d7654f73a217f6da87032843f93e173a80ea2", "new_mode": 33188, "new_path": "core/fpdfdoc/cba_fontmap.cpp" }, { "type": "modify", "old_id": "f4abfbab7f0d7605174685d05f4355805baa4fb8", "old_mode": 33188, "old_path": "core/fpdfdoc/cba_fontmap.h", "new_id": "ae148098f51d04e7fc98cb0b904b335fd97217a3", "new_mode": 33188, "new_path": "core/fpdfdoc/cba_fontmap.h" }, { "type": "modify", "old_id": "d7491e54c006d074f66b318b1e2f8f0138cacf17", "old_mode": 33188, "old_path": "core/fpdfdoc/cpdf_formcontrol.cpp", "new_id": "5d1efb86dbad736bd8409a7ff00ff58f58d8b5b1", "new_mode": 33188, "new_path": "core/fpdfdoc/cpdf_formcontrol.cpp" }, { "type": "modify", "old_id": "778e0794de512a95ef5e767d9c76812945512121", "old_mode": 33188, "old_path": "core/fpdfdoc/cpdf_formcontrol.h", "new_id": "18c1f23125ac44699e91a6df87440289d5d258a4", "new_mode": 33188, "new_path": "core/fpdfdoc/cpdf_formcontrol.h" }, { "type": "modify", "old_id": "b8d01f87c921d08647929651873b4ee39d694697", "old_mode": 33188, "old_path": "core/fpdfdoc/cpdf_formfield.cpp", "new_id": "7b1b6ffe1df50a7800659527387a803756dba0a9", "new_mode": 33188, "new_path": "core/fpdfdoc/cpdf_formfield.cpp" }, { "type": "modify", "old_id": "ab816510af962bf40fd2e055b6662002df120612", "old_mode": 33188, "old_path": "core/fpdfdoc/cpdf_formfield.h", "new_id": "a07720fc6a154f615143df07b89f259d9f0c905d", "new_mode": 33188, "new_path": "core/fpdfdoc/cpdf_formfield.h" }, { "type": "modify", "old_id": "2d9ff057833c681d3b223e7c9f90281f73a0dbbb", "old_mode": 33188, "old_path": "core/fpdfdoc/cpdf_interactiveform.cpp", "new_id": "e8103834efd94c2546d0da0356eb0b5a2bdd6d39", "new_mode": 33188, "new_path": "core/fpdfdoc/cpdf_interactiveform.cpp" }, { "type": "modify", "old_id": "91de032a09888af7a526005a4132b22b9106148f", "old_mode": 33188, "old_path": "core/fpdfdoc/cpdf_interactiveform.h", "new_id": "6d66f83c5aca9ca68b13b248ce157453df75d1e9", "new_mode": 33188, "new_path": "core/fpdfdoc/cpdf_interactiveform.h" }, { "type": "modify", "old_id": "fea74445d9c0ca79503e261e5ac50c7b82ba42ec", "old_mode": 33188, "old_path": "core/fpdfdoc/cpdf_variabletext.cpp", "new_id": "4373dd6dc8c403e51a5594b1b68e941556b50428", "new_mode": 33188, "new_path": "core/fpdfdoc/cpdf_variabletext.cpp" }, { "type": "modify", "old_id": "635869a334ab43c2770738ebbadb5830e39dd214", "old_mode": 33188, "old_path": "core/fpdfdoc/cpvt_fontmap.cpp", "new_id": "038a6f4d497c26bb456fe3446706868f08c64f2a", "new_mode": 33188, "new_path": "core/fpdfdoc/cpvt_fontmap.cpp" }, { "type": "modify", "old_id": "cce03bf5d282ef19663829c3a8510229f5b09821", "old_mode": 33188, "old_path": "core/fpdfdoc/cpvt_fontmap.h", "new_id": "a85afcfb833700cdcb0214bdad350c6462fe40a0", "new_mode": 33188, "new_path": "core/fpdfdoc/cpvt_fontmap.h" }, { "type": "modify", "old_id": "3a9a16df9cbf94d75b72d9314e3cda6f48009677", "old_mode": 33188, "old_path": "core/fpdfdoc/cpvt_generateap.cpp", "new_id": "4bd50dbc19e412248628a9783189cce45ede2d7d", "new_mode": 33188, "new_path": "core/fpdfdoc/cpvt_generateap.cpp" }, { "type": "modify", "old_id": "a27c0ac28a4f86425921dece0ec72df401602e53", "old_mode": 33188, "old_path": "core/fpdfdoc/ipvt_fontmap.h", "new_id": "e818356ddb63e700f464077599ff5467909abdf1", "new_mode": 33188, "new_path": "core/fpdfdoc/ipvt_fontmap.h" }, { "type": "modify", "old_id": "1ba470f7db16140d74694fb9c47da3261f699a9d", "old_mode": 33188, "old_path": "core/fpdftext/cpdf_textpage.cpp", "new_id": "4c9924748445a6683b0038abff6c44f4021ba4ea", "new_mode": 33188, "new_path": "core/fpdftext/cpdf_textpage.cpp" }, { "type": "modify", "old_id": "f3af83922ce9b1867a52344f64c69e13b7c4d094", "old_mode": 33188, "old_path": "fpdfsdk/fpdf_edit_embeddertest.cpp", "new_id": "a8c33c776cdd8d18e1e85fc7ae27c79d85573ccf", "new_mode": 33188, "new_path": "fpdfsdk/fpdf_edit_embeddertest.cpp" }, { "type": "modify", "old_id": "ce4c4148404874b95f5fab2c03136e76253a70ac", "old_mode": 33188, "old_path": "fpdfsdk/fpdf_edittext.cpp", "new_id": "1cc703c2e9413cff3f6b190116b613d1e63113b6", "new_mode": 33188, "new_path": "fpdfsdk/fpdf_edittext.cpp" }, { "type": "modify", "old_id": "2421ea24760f0c96e3d12e5ec245a4c73a27418f", "old_mode": 33188, "old_path": "fpdfsdk/fpdf_text.cpp", "new_id": "21aec91c8a1ca5a08c0fc19b71567a26cf259bcc", "new_mode": 33188, "new_path": "fpdfsdk/fpdf_text.cpp" }, { "type": "modify", "old_id": "261b274f84a8bb54319500e1f0c3bf4eaff47599", "old_mode": 33188, "old_path": "fpdfsdk/pwl/cpwl_appstream.cpp", "new_id": "eeac642768cfee1ac56a3354a10afaf63bd0c4bc", "new_mode": 33188, "new_path": "fpdfsdk/pwl/cpwl_appstream.cpp" }, { "type": "modify", "old_id": "6f529711172b94caaafef817447b94bfc6b8b51d", "old_mode": 33188, "old_path": "fpdfsdk/pwl/cpwl_edit.cpp", "new_id": "1aab8ef642f8c032828be6d9688028d8aae772b8", "new_mode": 33188, "new_path": "fpdfsdk/pwl/cpwl_edit.cpp" }, { "type": "modify", "old_id": "613cda9a8f4b79ff54867b1f57b2f16b510ede62", "old_mode": 33188, "old_path": "fpdfsdk/pwl/cpwl_edit_impl.cpp", "new_id": "80e1367cc03c2d5974a3ec55d549d626a31a9de6", "new_mode": 33188, "new_path": "fpdfsdk/pwl/cpwl_edit_impl.cpp" }, { "type": "modify", "old_id": "a9a9368fd44715827e279e77c85aafbec957d6f8", "old_mode": 33188, "old_path": "fxjs/cjs_document.cpp", "new_id": "34b5e2a0d71580c1ed42655f5f6ca011bb4818f6", "new_mode": 33188, "new_path": "fxjs/cjs_document.cpp" }, { "type": "modify", "old_id": "dd3dd02df6ca0a470ccfeb9c5a21fdd61c3cd704", "old_mode": 33188, "old_path": "fxjs/cjs_field.cpp", "new_id": "4399d307a20862597ba136a85cd446cedd6d6892", "new_mode": 33188, "new_path": "fxjs/cjs_field.cpp" }, { "type": "modify", "old_id": "b6df86675bcf9f9dcfee4b4e7bd9b4067b12be42", "old_mode": 33188, "old_path": "public/fpdf_edit.h", "new_id": "5596c551fb35bfee2c58e9e13e5e5b64f2509b72", "new_mode": 33188, "new_path": "public/fpdf_edit.h" }, { "type": "modify", "old_id": "23c06623102795d285bd337d81fe5a3662154083", "old_mode": 33188, "old_path": "xfa/fgas/font/cfgas_gefont.cpp", "new_id": "6ef72b9ff632084ed58b9a5d780e412cc0243d1c", "new_mode": 33188, "new_path": "xfa/fgas/font/cfgas_gefont.cpp" }, { "type": "modify", "old_id": "30c439529c3775a5d7d9bcfb013ad06a0a5ace9b", "old_mode": 33188, "old_path": "xfa/fgas/font/cfgas_gefont.h", "new_id": "b7988db0fd463ec9cad81b17c28f526b95761a20", "new_mode": 33188, "new_path": "xfa/fgas/font/cfgas_gefont.h" }, { "type": "modify", "old_id": "4cdaffa0f9daba0bae589ad60e4183d273a55beb", "old_mode": 33188, "old_path": "xfa/fgas/font/cfgas_pdffontmgr.cpp", "new_id": "e020007e131a709346ce489829da229c7cc9139f", "new_mode": 33188, "new_path": "xfa/fgas/font/cfgas_pdffontmgr.cpp" }, { "type": "modify", "old_id": "f78de6639997bf7bf3dc705d19e6fa57615eba04", "old_mode": 33188, "old_path": "xfa/fxfa/cxfa_fontmgr.cpp", "new_id": "c7ced0c3d732da3b1fe3f215d9878a80ff67f237", "new_mode": 33188, "new_path": "xfa/fxfa/cxfa_fontmgr.cpp" } ] }