)]}'
{
  "commit": "76c53794b6202ec37f6dcace5f2ae86870e953b6",
  "tree": "b7c9fce179cee0be2ac01ff966e6521169831e03",
  "parents": [
    "186a78eb0a821a2f1feef524cb590d0fea2009ba"
  ],
  "author": {
    "name": "dsinclair",
    "email": "dsinclair@chromium.org",
    "time": "Tue Apr 26 11:05:26 2016 -0700"
  },
  "committer": {
    "name": "Commit bot",
    "email": "commit-bot@chromium.org",
    "time": "Tue Apr 26 11:05:26 2016 -0700"
  },
  "message": "Fix Wvarargs warning in XFA error code.\n\nChrome has enabled the -Wvarargs warning that was added to clang, this fails\nwith PDFium XFA builds due to two warnings:\n\n../../xfa/fxfa/fm2js/xfa_lexer.cpp:539:16: error: passing an object that\nundergoes default argument promotion to \u0027va_start\u0027 has undefined behavior\n[-Werror,-Wvarargs]\n  va_start(ap, msg);\n               ^\n../../xfa/fxfa/fm2js/xfa_lexer.cpp:535:40: note: parameter of type\n\u0027XFA_FM_ERRMSG\u0027 is declared here\nvoid CXFA_FMLexer::Error(XFA_FM_ERRMSG msg, ...) {\n\nThe issue is that XFA_FM_ERRMSG is an enum and we violate the promotion rules\nfor passing the value to va_start.\n\nI removed the enum and named the flags explicitly then pass in the string as\nthe argument.\n\nBUG\u003dchromium:606726\n\nReview URL: https://codereview.chromium.org/1921323002\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "9bfcec6efe4ed22190aa8988a63a73f329d823b6",
      "old_mode": 33188,
      "old_path": "DEPS",
      "new_id": "7fb3a32b6e2e4f76990e7d8179ace08e419b796c",
      "new_mode": 33188,
      "new_path": "DEPS"
    },
    {
      "type": "modify",
      "old_id": "4b5b74072aacd8ae5e54059349132cf473d27233",
      "old_mode": 33188,
      "old_path": "build_gyp/standalone.gypi",
      "new_id": "ad7ebdaac03c017ca585c68c5244ee7c3e69b487",
      "new_mode": 33188,
      "new_path": "build_gyp/standalone.gypi"
    },
    {
      "type": "modify",
      "old_id": "2f3c07962fe859e206c9060a8431f0643f8bc9c7",
      "old_mode": 33188,
      "old_path": "build_overrides/v8.gni",
      "new_id": "2b50795fd6b93d4087095daf95b5ce1589a242a2",
      "new_mode": 33188,
      "new_path": "build_overrides/v8.gni"
    },
    {
      "type": "modify",
      "old_id": "69ce6083189f562f6f3fee93d208e3b01d3949f0",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/fm2js/xfa_error.cpp",
      "new_id": "020d9bc5091acc0e1d8e83f9d292987485578667",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/fm2js/xfa_error.cpp"
    },
    {
      "type": "modify",
      "old_id": "2415cd321263bdf07c19ba1f2af753854c8c6c61",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/fm2js/xfa_error.h",
      "new_id": "6ce102e03eb388ee08b1c3be74fc88d933f8e84e",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/fm2js/xfa_error.h"
    },
    {
      "type": "modify",
      "old_id": "c99f015fca8ce5f9593ed3cd20bc1abbf1313424",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/fm2js/xfa_fmparse.cpp",
      "new_id": "a917e23b8b83d50e18ec062c558c821c07da52e5",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/fm2js/xfa_fmparse.cpp"
    },
    {
      "type": "modify",
      "old_id": "288ae907449f032d2590105b8dd7d90d89b824dd",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/fm2js/xfa_fmparse.h",
      "new_id": "014eccee08e5a60b5b436972533a2fc7f817c6fe",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/fm2js/xfa_fmparse.h"
    },
    {
      "type": "modify",
      "old_id": "dd3b48ff54f509b67a5f2fe0cd88e58e9621e7ab",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/fm2js/xfa_lexer.cpp",
      "new_id": "f048f42668a72e9eb225050015387892451a08ef",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/fm2js/xfa_lexer.cpp"
    },
    {
      "type": "modify",
      "old_id": "fd89dc72ebdd8799dfaa728f3f9f70e4515c6bf6",
      "old_mode": 33188,
      "old_path": "xfa/fxfa/fm2js/xfa_lexer.h",
      "new_id": "c21c00255aa37fad4b0a6ef67417e7e604b8e033",
      "new_mode": 33188,
      "new_path": "xfa/fxfa/fm2js/xfa_lexer.h"
    }
  ]
}